Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid setting p0 to None during assignment #543

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

faridyagubbayli
Copy link
Collaborator

Fixed #468

Not sure why we even have a logic to assign p0 to None. Could not find any reason.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.12%. Comparing base (36b7e9a) to head (e7e5e8a).

Files with missing lines Patch % Lines
kwave/ksource.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #543   +/-   ##
=======================================
  Coverage   73.11%   73.12%           
=======================================
  Files          46       46           
  Lines        6830     6831    +1     
  Branches     1308     1308           
=======================================
+ Hits         4994     4995    +1     
  Misses       1286     1286           
  Partials      550      550           
Flag Coverage Δ
3.10 73.12% <50.00%> (+<0.01%) ⬆️
3.11 73.12% <50.00%> (+<0.01%) ⬆️
3.12 73.12% <50.00%> (+<0.01%) ⬆️
3.13 73.12% <50.00%> (+<0.01%) ⬆️
macos-latest 73.09% <50.00%> (+<0.01%) ⬆️
ubuntu-latest 73.09% <50.00%> (+<0.01%) ⬆️
windows-latest 73.10% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling p0 input in source
1 participant