Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate number of threads (-t) option on windows #514

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Conversation

waltsims
Copy link
Owner

Closes #513

@waltsims waltsims self-assigned this Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.79%. Comparing base (bb57cc4) to head (7c6f0df).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #514      +/-   ##
==========================================
+ Coverage   72.77%   72.79%   +0.01%     
==========================================
  Files          46       46              
  Lines        6789     6789              
  Branches     1305     1305              
==========================================
+ Hits         4941     4942       +1     
  Misses       1290     1290              
+ Partials      558      557       -1     
Flag Coverage Δ
3.10 72.79% <100.00%> (+0.01%) ⬆️
3.11 72.79% <100.00%> (+0.01%) ⬆️
3.12 72.79% <100.00%> (+0.01%) ⬆️
3.13 72.79% <100.00%> (+0.01%) ⬆️
macos-latest 72.76% <100.00%> (+0.01%) ⬆️
ubuntu-latest 72.76% <100.00%> (+0.01%) ⬆️
windows-latest 72.76% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@faridyagubbayli faridyagubbayli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment

tests/test_simulation_execution_options.py Show resolved Hide resolved
@waltsims waltsims merged commit 16d23c1 into master Nov 22, 2024
44 checks passed
@waltsims waltsims deleted the bugfix/#513 branch November 22, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Windows CUDA binary fails with threads (-t) option in k-wave-python 0.3.6
2 participants