Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NODE-5565 Add configuration parameter for Nginx extended logs #206

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

braek-neck
Copy link
Contributor

@braek-neck braek-neck commented Jan 15, 2025

No description provided.

@github-actions github-actions bot added helm Helm chart related changes controller Controller related changes labels Jan 15, 2025
@braek-neck braek-neck changed the title NODE-5565 [Sidecar] Add configuration parameter for Nginx extended lo… NODE-5565 Add configuration parameter for Nginx extended logs Jan 15, 2025
@braek-neck braek-neck force-pushed the NODE-5565-sidecar-nginx-logs branch 5 times, most recently from 7531a8b to ffb993f Compare January 16, 2025 08:13
@braek-neck braek-neck marked this pull request as draft January 16, 2025 08:20
@braek-neck braek-neck force-pushed the NODE-5565-sidecar-nginx-logs branch 4 times, most recently from 8ef42a4 to a2cb675 Compare January 17, 2025 06:30
@braek-neck braek-neck marked this pull request as ready for review January 17, 2025 07:09
helm/values.yaml Outdated Show resolved Hide resolved
files/template.yaml.tpl Outdated Show resolved Hide resolved
files/template.yaml.tpl Outdated Show resolved Hide resolved
@xDmitriev
Copy link
Member

Are you going to update wallarm/sidecar image tag?

@braek-neck braek-neck force-pushed the NODE-5565-sidecar-nginx-logs branch from a2cb675 to 26762e3 Compare January 21, 2025 07:53
@braek-neck
Copy link
Contributor Author

Are you going to update wallarm/sidecar image tag?

will be update on next release.

@xDmitriev
Copy link
Member

Are you going to update wallarm/sidecar image tag?

will be update on next release.

@braek-neck how do you test that it works?

@braek-neck
Copy link
Contributor Author

Are you going to update wallarm/sidecar image tag?

will be update on next release.

@braek-neck how do you test that it works?

with rc sidecar image that was built for test this.

@braek-neck braek-neck merged commit 3688426 into main Jan 22, 2025
34 checks passed
@braek-neck braek-neck deleted the NODE-5565-sidecar-nginx-logs branch January 22, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controller Controller related changes helm Helm chart related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants