Skip to content

Commit

Permalink
Do not ignore any fields when generating spec.
Browse files Browse the repository at this point in the history
Deprecated fields have been removed from the repository.
One deprecated tag was reintroduced to the spec as another field.
  • Loading branch information
Oren Miller authored and Oren Miller committed Jan 12, 2017
1 parent 3e87689 commit 8e538f1
Show file tree
Hide file tree
Showing 13 changed files with 80 additions and 8 deletions.
5 changes: 4 additions & 1 deletion spec/FIX50SP1.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5092,7 +5092,9 @@
</group>
</component>
<component name='UsernameGrp'>
<field name='Username' required='N' />
<group name='NoUsernames' required='N'>
<field name='Username' required='N' />
</group>
</component>
<component name='NotAffectedOrdersGrp'>
<group name='NoNotAffectedOrders' required='N'>
Expand Down Expand Up @@ -8069,6 +8071,7 @@
<value enum='5' description='BLOCK_LEVEL_REJECT' />
<value enum='6' description='ACCOUNT_LEVEL_REJECT' />
</field>
<field number='809' name='NoUsernames' type='NUMINGROUP' />
<field number='810' name='UnderlyingPx' type='PRICE' />
<field number='811' name='PriceDelta' type='FLOAT' />
<field number='812' name='ApplQueueMax' type='INT' />
Expand Down
5 changes: 4 additions & 1 deletion spec/FIX50SP2.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5211,7 +5211,9 @@
</group>
</component>
<component name='UsernameGrp'>
<field name='Username' required='N' />
<group name='NoUsernames' required='N'>
<field name='Username' required='N' />
</group>
</component>
<component name='NotAffectedOrdersGrp'>
<group name='NoNotAffectedOrders' required='N'>
Expand Down Expand Up @@ -8347,6 +8349,7 @@
<value enum='5' description='BLOCK_LEVEL_REJECT' />
<value enum='6' description='ACCOUNT_LEVEL_REJECT' />
</field>
<field number='809' name='NoUsernames' type='NUMINGROUP' />
<field number='810' name='UnderlyingPx' type='PRICE' />
<field number='811' name='PriceDelta' type='FLOAT' />
<field number='812' name='ApplQueueMax' type='INT' />
Expand Down
8 changes: 4 additions & 4 deletions spec/generate_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,9 @@ def initialize( major, minor, sp )
end

def tagShouldBeSkipped( tag )
return true if tag == 101
return true if tag == 261
return true if tag == 809
#return true if tag == 101
#return true if tag == 261
#return true if tag == 809
end

def tagShouldNotPrint( tag )
Expand Down Expand Up @@ -419,4 +419,4 @@ def printDictionary

(0..4).each { |i| DataDictionary.new( 4, i, 0 ) }
(0..2).each { |i| DataDictionary.new( 5, 0, i ) }
DataDictionary.new( 5, 0, 0 )

1 change: 1 addition & 0 deletions src/C++/FixFieldNumbers.h
Original file line number Diff line number Diff line change
Expand Up @@ -1160,6 +1160,7 @@ namespace FIX
const int AllocClearingFeeIndicator = 1136;
const int DisplayQty = 1138;
const int ExchangeSpecialInstructions = 1139;
const int NoUsernames = 809;
const int ExpirationQtyType = 982;
const int MaxTradeVol = 1140;
const int NoMDFeedTypes = 1141;
Expand Down
1 change: 1 addition & 0 deletions src/C++/FixFields.h
Original file line number Diff line number Diff line change
Expand Up @@ -1162,6 +1162,7 @@ namespace FIX
DEFINE_STRING(AllocClearingFeeIndicator);
DEFINE_QTY(DisplayQty);
DEFINE_STRING(ExchangeSpecialInstructions);
DEFINE_NUMINGROUP(NoUsernames);
DEFINE_INT(ExpirationQtyType);
DEFINE_QTY(MaxTradeVol);
DEFINE_NUMINGROUP(NoMDFeedTypes);
Expand Down
8 changes: 7 additions & 1 deletion src/C++/fix50sp1/UserNotification.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,13 @@ namespace FIX50SP1
set(aUserStatus);
}

FIELD_SET(*this, FIX::Username);
FIELD_SET(*this, FIX::NoUsernames);
class NoUsernames: public FIX::Group
{
public:
NoUsernames() : FIX::Group(809,553,FIX::message_order(553,0)) {}
FIELD_SET(*this, FIX::Username);
};
FIELD_SET(*this, FIX::UserStatus);
FIELD_SET(*this, FIX::Text);
FIELD_SET(*this, FIX::EncodedTextLen);
Expand Down
8 changes: 7 additions & 1 deletion src/C++/fix50sp2/UserNotification.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,13 @@ namespace FIX50SP2
set(aUserStatus);
}

FIELD_SET(*this, FIX::Username);
FIELD_SET(*this, FIX::NoUsernames);
class NoUsernames: public FIX::Group
{
public:
NoUsernames() : FIX::Group(809,553,FIX::message_order(553,0)) {}
FIELD_SET(*this, FIX::Username);
};
FIELD_SET(*this, FIX::UserStatus);
FIELD_SET(*this, FIX::Text);
FIELD_SET(*this, FIX::EncodedTextLen);
Expand Down
7 changes: 7 additions & 0 deletions src/python/quickfix50sp1.py
Original file line number Diff line number Diff line change
Expand Up @@ -14270,3 +14270,10 @@ class UserNotification(Message):
def __init__(self):
Message.__init__(self)
self.getHeader().setField( fix.MsgType("CB") )

class NoUsernames(fix.Group):
def __init__(self):
order = fix.IntArray(2)
order[0] = 553
order[1] = 0
fix.Group.__init__(self, 809, 553, order)
7 changes: 7 additions & 0 deletions src/python/quickfix50sp2.py
Original file line number Diff line number Diff line change
Expand Up @@ -15387,6 +15387,13 @@ def __init__(self):
Message.__init__(self)
self.getHeader().setField( fix.MsgType("CB") )

class NoUsernames(fix.Group):
def __init__(self):
order = fix.IntArray(2)
order[0] = 553
order[1] = 0
fix.Group.__init__(self, 809, 553, order)

class StreamAssignmentRequest(Message):
def __init__(self):
Message.__init__(self)
Expand Down
7 changes: 7 additions & 0 deletions src/python/quickfix_fields.py
Original file line number Diff line number Diff line change
Expand Up @@ -8085,6 +8085,13 @@ def __init__(self, data = None):
else:
quickfix.StringField.__init__(self, 1139, data)

class NoUsernames(quickfix.IntField):
def __init__(self, data = None):
if data == None:
quickfix.IntField.__init__(self, 809)
else:
quickfix.IntField.__init__(self, 809, data)

class ExpirationQtyType(quickfix.IntField):
def __init__(self, data = None):
if data == None:
Expand Down
9 changes: 9 additions & 0 deletions src/ruby/quickfix50sp1.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15625,5 +15625,14 @@ def initialize
super
getHeader().setField( Quickfix::MsgType.new("CB") )
end

class NoUsernames < Quickfix::Group
def initialize
order = Quickfix::IntArray.new(2)
order[0] = 553
order[1] = 0
super(809, 553, order)
end
end
end
end
9 changes: 9 additions & 0 deletions src/ruby/quickfix50sp2.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16791,6 +16791,15 @@ def initialize
super
getHeader().setField( Quickfix::MsgType.new("CB") )
end

class NoUsernames < Quickfix::Group
def initialize
order = Quickfix::IntArray.new(2)
order[0] = 553
order[1] = 0
super(809, 553, order)
end
end
end

class StreamAssignmentRequest < Message
Expand Down
13 changes: 13 additions & 0 deletions src/ruby/quickfix_fields.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15014,6 +15014,19 @@ def initialize(data = nil)
end
end

class NoUsernames < Quickfix::IntField
def NoUsernames.field
return 809
end
def initialize(data = nil)
if( data == nil )
super(809)
else
super(809, data)
end
end
end

class ExpirationQtyType < Quickfix::IntField
def ExpirationQtyType.field
return 982
Expand Down

0 comments on commit 8e538f1

Please sign in to comment.