Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Best Pre-Vote Candidate in GRANDPA Spec #734

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Fix Best Pre-Vote Candidate in GRANDPA Spec #734

merged 2 commits into from
Jan 17, 2025

Conversation

drskalman
Copy link
Contributor

closes #733

  • Best Prevote should come from last round's GHOST.
  • We should return the best chain safe head of that GHOST.

@drskalman
- Best Prevote should come from last round's GHOST.
cb37f15 
- We should return the best chain safe head of that GHOST.
bhargavbh
bhargavbh approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@bhargavbh bhargavbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we need to make any changes in the BABE section s.t it is consistent with the "Best Safe Chain Head" terminology?

@Noc2 Noc2 merged commit 3b1afed into main Jan 17, 2025
3 checks passed
@Noc2 Noc2 deleted the skalman--fix-grandpa-best-pre-vote-candidate branch January 17, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noc2 Noc2 Noc2 approved these changes

@bhargavbh bhargavbh bhargavbh approved these changes

@AlistairStewart AlistairStewart Awaiting requested review from AlistairStewart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GRANDPA pre-vote selection algorithm
3 participants
@drskalman @Noc2 @bhargavbh