Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New principle: Where possible APIs should be available in DedicatedWorker #356

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

kenchris
Copy link
Contributor

@kenchris kenchris commented Jan 25, 2022

Closes #325


Preview | Diff

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this advice be made more generic to cover all types of workers?

I suspect folks also might want guidance around worklets and Exposed=*.

index.bs Outdated
Comment on lines 2543 to 2544
A DedicatedWorker is a non specialized worker type that allows developers to run code
off the main thread.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just reference back to DedicatedWorker and not explain this ourselves.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then devs will have to open multiple links, maybe do both?

@kenchris
Copy link
Contributor Author

@annevk if you have suggestions, please share. I think we want to land something now and then fix in follow ups as we get consensus

index.bs Outdated Show resolved Hide resolved
Co-authored-by: Sangwhan "fish" Moon <[email protected]>
@kenchris kenchris merged commit 8388c68 into w3ctag:main Jan 27, 2022
@annevk
Copy link
Member

annevk commented Jan 28, 2022

I filed #359 as a follow-up. I'm a bit surprised this was just landed without some more time for back-and-forth discussion. At least in the past updates to this document were done quite carefully.

hober pushed a commit that referenced this pull request Apr 20, 2023
…rker (#356)

* New principle: Where possible APIs should be made available in DedicatedWorker

* Remove description of dedicated worker

Co-authored-by: Sangwhan "fish" Moon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guidance about exposing on Window vs Worker only (and other contexts)
3 participants