Improve capability delegation example and explanation #875
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wip-abramson
requested review from
msporny,
dmitrizagidulin,
mccown,
ChristopherA and
danpape
as code owners
msporny
approved these changes
Jan 4, 2025
msporny
reviewed
Jan 4, 2025
msporny
reviewed
Jan 4, 2025
msporny
added
the
class 2
dlongley
reviewed
Jan 4, 2025
Co-authored-by: Dave Longley <[email protected]>
Co-authored-by: Manu Sporny <[email protected]>
TallTed
reviewed
Jan 6, 2025
Comment on lines
+2142
to
+2143
| can be used to verify delegated capabilities issued by | ||
| <code>did:example:123456789abcdefghi</code>. |
There was a problem hiding this comment.
delegated capabilities issued by reads oddly to me. Does this work?
Suggested change
| can be used to verify delegated capabilities issued by | |
| <code>did:example:123456789abcdefghi</code>. | |
| can be used to verify capabilities delegated by | |
| <code>did:example:123456789abcdefghi</code>. |
There was a problem hiding this comment.
This works for me. @dlongley?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this clarifies the confusion raised in #812
Preview | Diff