Fix lookup of series for diff building #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When diff building a spec, other specs in the same series need to be re-built as well. The code correctly picked up the other specs in the same series but forgot that entries in `specs.json` may either be a string or an object with a `url` property when it removed duplicates, leading to an incomplete list in the end. Fixes #1713
dontcallmedom
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When diff building a spec, other specs in the same series need to be re-built as well. The code correctly picked up the other specs in the same series but forgot that entries in
specs.jsonmay either be a string or an object with aurlproperty when it removed duplicates, leading to an incomplete list in the end.Fixes #1713