editorial: revise custom stylesheets #2410

pkra · 2025-01-09T08:47:31Z

Resolves #2226

remove common.css
- reduce css as per remove spec specific css or inline it #2226 (comment)
- .image => remove after switching markup to figure
- remove all other styles
- remove stylesheet and switch to respec options
  - add custom styles to accname to make up for nested OL styles
  - adjust tables
    - aria: replace with .def and .data
    - accname: 1 table => .data
    - core-aam: tables => .def (as per Move all AAM specs to use w3c's "data tables" #2229)
    - dpub-aam: tables => .def (as per Move all AAM specs to use w3c's "data tables" #2229)
    - dpub-aria: replace with .def
    - graphics-aam: tables => .def (as per Move all AAM specs to use w3c's "data tables" #2229)
    - graphics-aria: replace with .data
    - html-aam: tables => .def (as per Move all AAM specs to use w3c's "data tables" #2229)
    - mathml-aam: tables => .def (as per Move all AAM specs to use w3c's "data tables" #2229)
    - pdf-aam: tables => .def (as per Move all AAM specs to use w3c's "data tables" #2229)
    - svg-aam: tables => .def (as per Move all AAM specs to use w3c's "data tables" #2229)
    - also update graphics2.html and aria-requirements.html
  - remove common.css
  - remove mapping-tables.css
- review color contrast issues
  - => color contrast issues speced/respec#4871
  - dark mode: th{ background-color:#eee; } (cf. Text-to-background contrast in tables under ARIA's Definition of Roles too low #2394 + duplicates)
    - will be resolved by dropping common.css (cf. above)
  - syntax highlighting (light mode: IDL - dark mode: almost every code example) => follow up to css revision #2433
    - track: switch to more accessible highlight.js palette => follow up to css revision #2433
    - track incorrect language detection such as #example-48 => https://github.com/speced/respec/wiki/ReSpec-Editor's-Guide#examples => follow up to css revision #2433
revise core-aam.css
- reduce css as per remove spec specific css or inline it #2226 (comment)
- remove core-aam.css as they are covered via common.css
pdf-aam: remove link to (now removed) core-aam.css
accname styles
- check remove spec specific css or inline it #2226 (comment) => less than reduced common.css for aria [the stylesheet has already been dropped]
mapping-tables.css
- replace with .data as per review mapping-tables.css #2435 , Move all AAM specs to use w3c's "data tables" #2229 [cf. notes above]
editors.css - remove
slices.css - remove
html-aam.css - remove

netlify · 2025-01-09T08:48:13Z

✅ Deploy Preview for wai-aria ready!

Name	Link
🔨 Latest commit	`c9185c2`
🔍 Latest deploy log	https://app.netlify.com/sites/wai-aria/deploys/67af071d5ec7ad00081cab73
😎 Deploy Preview	https://deploy-preview-2410--wai-aria.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pkra · 2025-01-09T09:19:27Z

notes to self:

the reduction of common.css in remove spec specific css or inline it #2226 (comment) includes more declarations than the reductions in remove spec specific css or inline it #2226 (comment) (core-aam) and remove spec specific css or inline it #2226 (comment) (accname). So we can start there.
core-aam loads both core-aam.css and common.css so we can reduce core-aam.css further

pkra · 2025-01-09T12:14:45Z

It turns out, core-aam only sets styling that are already set in common.css.

pkra · 2025-01-10T17:09:45Z

@jnurthen @spectranaut @daniel-montalvo I think I actually want to suggest to remove all of common.css.

Almost all of it is minor stylistic differences to what respec does (i.e., everything after the table styles).

For tables, I would suggest to switch to respec's table.def styles. Very different but that's what they're for and it seems better to stick with respec for maintenance.

The only other bit are the nested lists styles. However, only accname actually needs these (and I feel like respec or W3C TR styles should be doing a better job here - but they probably don't want to risk it but perhaps be open to opt-in classes).

[For completeness: there are 2 nested lists in aria in 4.3.2 - all other nested lists in specs are from respec TOCs where the styles are set by respec.]

I'll prep something for the next editors meeting so we can go through them together.

pkra · 2025-01-23T07:52:39Z

Discussed in editors' call https://www.w3.org/2025/01/22-aria-editors-minutes.html#1b79

tl;dr I will continue this PR to effectively remove common.css

pkra · 2025-01-23T08:12:04Z

@jnurthen looking through https://w3c.github.io/tr-design/src/README I see 1-2 other table styles: .data and .index (which is like .data but more cramped). They look more like our current tables, but have noticeably more whitespace.

Are there others you had in mind?

jnurthen · 2025-01-23T16:08:05Z

Are there others you had in mind?

I think I was thinking about the default style without data for some of the tables at the end of the doc

Removes styles that match 1 list in aria, accname, core-aam, pdf-aam; only 1 minor visual change in accname, otherwise margin-collapse helps. Part of #2410

All props are overruled by respec. Part of #2410

As per editors discussion, we switch to the default respec style. Part of #2410

As per editors discussion, we switch to the default respec style. Cf. #2433 for follow up on aria.js (which generates these elements). Part of #2410

As per editors discussion, we switch to the default respec style. Part of #2410

As per editors discussion, we switch to default respec / highlightjs styles. Part of #2410

As per editors discussion, we remove the nested list and add a style block with custom classes to accname. - common.css: remove nested OL styles - accname/index.html - add style block with custom classes - add appropriate classes to nested lists in 4.3.2 (except in the first note and example 3) Part of #2410

As per editors discussion, removes common.css and adds respec classes to tables. - switches existing classes to .def - adds .def to IDL correspondance table - switches 2 classless tables to "data" Part of #2410

This file no longer appears to be used anywhere. Part of #2410

pkra · 2025-02-12T20:03:50Z

As per today's call, I will switch the other specs to using respec table classes.

Then the editors can review each spec.

@MelSumner could you take a look at the nested list classes I've added to accname 42082b0? @spectranaut suggested it might be better to design the lists in a way so that new nested lists can be added without having to remember the right class. It seems prudent to ask a spec editor to do that 😄

As per editors discussion, we remove the nested list and add a style block with custom classes to accname. - common.css: remove nested OL styles - accname/index.html - add style block with custom classes - add appropriate classes to nested lists in 4.3.2 (except in the first note and example 3) Part of #2410

As per editors discussion, removes common.css and adds respec classes to tables. - switches existing classes to .def - adds .def to IDL correspondance table - switches 2 classless tables to "data" Part of #2410

This file no longer appears to be used anywhere. Part of #2410

Removes common.css and adds respec class "data" to the table (in "4.2 Description Computation"). Part of #2410

As per editors discussion, removes common.css and replaces .role-features with respec's .def Part of #2410

Removes common.css and mapping-tables.css and adds respec's .data to all tables Part of #2410

As per editors discussion, removes common.css and replaces table classes with respec's .def Part of #2410

At long last, it is longer in use. Part of #2410

pkra · 2025-02-13T16:36:39Z

This is ready for review.

While rebasing I fixed a typo in html-aam (extraneous closing parenthesis in the img alt section).

spectranaut

I have one request about the CSS for nested lists, I'd like @MelSumner to weigh in as she is the visual editor of that spec :)

Also -- I think we should have, perhaps a follow up issue, to make all the data tables in the aams use class=def to get the blue definition tables: https://www.w3.org/StyleSheets/TR/2021/README#def

spectranaut · 2025-02-13T19:17:08Z

accname/index.html

+    <style>
+      .ol--upperAlpha{ list-style:upper-alpha; } /* replaces: ol ol */
+      .ol--lowerRoman { list-style:lower-roman; } /* replaces: ol ol ol */
+      .ol--lowerAlpha { list-style:lower-alpha; } /* replaces: ol ol ol ol */


Can't we do something like putting the class "computation_algorithm" on the rool ol and then do:

.computation_algorithm ol ol { list-style:upper-alpha; } .computation_algorithm ol ol ol { list-style:lower-roman; } .computation_algorithm ol ol ol ol {l ist-style:lower-alpha; }

And remove those custom classes on the nest ols, so no one has to worry about adding then when they make a nested list in a computation?

Two minor notes:

if .computation_algorithm goes on an OL, this needs to drop one ol from each line.

then these styles would still affect the two lists in the Note and Example

As I said on the call, I have no strong feelings either way. But we can also work this out later. (I'm a little worried about merge conflicts as I'm touching all the specs.)

pkra · 2025-02-13T20:04:10Z

Also -- I think we should have, perhaps a follow up issue, to make all the data tables in the aams use class=def to get the blue definition tables: https://www.w3.org/StyleSheets/TR/2021/README#def

@spectranaut ugh, sorry, that's my fault. I misread #2229 and thought you wanted the .data style.

I'll update the PR tomorrow.

Properly address #2229 this time. Part of #2410

pkra · 2025-02-14T09:04:38Z

Also -- I think we should have, perhaps a follow up issue, to make all the data tables in the aams use class=def to get the blue definition tables: https://www.w3.org/StyleSheets/TR/2021/README#def

@spectranaut ugh, sorry, that's my fault. I misread #2229 and thought you wanted the .data style.

I'll update the PR tomorrow.

Done.

pkra added editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo Agenda-Editors labels Jan 9, 2025

github-actions bot added spec:core-aam spec:html-aam labels Jan 9, 2025

pkra self-assigned this Jan 9, 2025

github-actions bot added the spec:aria label Jan 9, 2025

github-actions bot added the spec:pdf-aam label Jan 9, 2025

pkra mentioned this pull request Jan 9, 2025

color contrast issues speced/respec#4871

Open

pkra mentioned this pull request Feb 8, 2025

Table caption, table headers, term definitions are almost unreadable in dark mode #2429

Closed

pkra added a commit that referenced this pull request Feb 12, 2025

editorial(common.css): remove custom termlist design

474ae57

Removes styles that match 1 list in aria, accname, core-aam, pdf-aam; only 1 minor visual change in accname, otherwise margin-collapse helps. Part of #2410

pkra added a commit that referenced this pull request Feb 12, 2025

editorial(common.css): remove .note

4bf2efb

All props are overruled by respec. Part of #2410

pkra mentioned this pull request Feb 12, 2025

follow up to css revision #2433

Open

4 tasks

pkra added a commit that referenced this pull request Feb 12, 2025

editorial(common.css): remove custom .rfc2119

9e6c191

As per editors discussion, we switch to the default respec style. Part of #2410

pkra added a commit that referenced this pull request Feb 12, 2025

editorial(common.css): remove dl.compact dt

e031ae4

As per editors discussion, we switch to the default respec style. Cf. #2433 for follow up on aria.js (which generates these elements). Part of #2410

pkra added a commit that referenced this pull request Feb 12, 2025

editorial(common.css): remove custom .termref

0ee19ff

As per editors discussion, we switch to the default respec style. Part of #2410

pkra added a commit that referenced this pull request Feb 12, 2025

editorial(common.css): remove code/pre/kbd styles

a96ab60

As per editors discussion, we switch to default respec / highlightjs styles. Part of #2410

github-actions bot added the spec:accname label Feb 12, 2025

pkra added a commit that referenced this pull request Feb 12, 2025

editorial: remove editors.css,

00c2455

This file no longer appears to be used anywhere. Part of #2410

pkra added a commit that referenced this pull request Feb 12, 2025

editorial: remove slices.css,

963998d

This file no longer appears to be used anywhere. Part of #2410

pkra mentioned this pull request Feb 12, 2025

review mapping-tables.css #2435

Closed

pkra added 17 commits February 13, 2025 17:28

editorial(aria): remove common.css & adjust tables

fdfa2ae

As per editors discussion, removes common.css and adds respec classes to tables. - switches existing classes to .def - adds .def to IDL correspondance table - switches 2 classless tables to "data" Part of #2410

editorial: remove editors.css,

c19df49

This file no longer appears to be used anywhere. Part of #2410

editorial: remove slices.css,

eabb800

This file no longer appears to be used anywhere. Part of #2410

editorial(accname): remove common.css & adjust table

5c9fe74

Removes common.css and adds respec class "data" to the table (in "4.2 Description Computation"). Part of #2410

editorial(dpub-aria): remove common.css & adjust tables

674601e

As per editors discussion, removes common.css and replaces .role-features with respec's .def Part of #2410

editorial(graphics-aria): remove common.css & adjust tables

75882a4

As per editors discussion, removes common.css and replaces .role-features with respec's .def Part of #2410

editorial(core-aam): remove stylesheets & adjust tables

fae7f26

Removes common.css and mapping-tables.css and adds respec's .data to all tables Part of #2410

editorial(dpub-aam): remove stylesheets & adjust tables

e14d2d7

Removes common.css and mapping-tables.css and adds respec's .data to all tables Part of #2410

editorial(graphics-aam): remove stylesheets & adjust tables

0b2e1cb

Removes common.css and mapping-tables.css and adds respec's .data to all tables Part of #2410

editorial(html-aam): remove stylesheets & adjust tables

649f3ee

Removes common.css and mapping-tables.css and adds respec's .data to all tables Part of #2410

editorial(mathml-aam): remove stylesheets & adjust tables

87cd9f5

Removes common.css and mapping-tables.css and adds respec's .data to all tables Part of #2410

editorial(pdf-aam): remove stylesheets & adjust tables

c942754

Removes common.css and mapping-tables.css and adds respec's .data to all tables Part of #2410

editorial(svg-aam): remove stylesheets & adjust tables

6228dd8

Removes common.css and mapping-tables.css and adds respec's .data to all tables Part of #2410

editorial: remove last references to common.css

24cc6d4

As per editors discussion, removes common.css and replaces table classes with respec's .def Part of #2410

editorial: remove common.css

ea47cb1

At long last, it is longer in use. Part of #2410

editorial: remove mapping-tables.css

ec71494

At long last, it is longer in use. Part of #2410

pkra force-pushed the issue2226 branch from c6bde66 to ec71494 Compare February 13, 2025 16:34

pkra marked this pull request as ready for review February 13, 2025 16:35

pkra requested review from spectranaut, jnurthen, scottaohara, MelSumner, rahimabdi and accdc February 13, 2025 16:35

spectranaut requested changes Feb 13, 2025

View reviewed changes

editorial(aam): switch tables to .def

c9185c2

Properly address #2229 this time. Part of #2410

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

editorial: revise custom stylesheets #2410

editorial: revise custom stylesheets #2410

pkra commented Jan 9, 2025 •

edited by pr-preview bot

Loading

netlify bot commented Jan 9, 2025 •

edited

Loading

pkra commented Jan 9, 2025

pkra commented Jan 9, 2025

pkra commented Jan 10, 2025

pkra commented Jan 23, 2025

pkra commented Jan 23, 2025

jnurthen commented Jan 23, 2025

pkra commented Feb 12, 2025

pkra commented Feb 13, 2025

spectranaut left a comment

spectranaut Feb 13, 2025

pkra Feb 14, 2025

pkra commented Feb 13, 2025

pkra commented Feb 14, 2025

editorial: revise custom stylesheets #2410

Are you sure you want to change the base?

editorial: revise custom stylesheets #2410

Conversation

pkra commented Jan 9, 2025 • edited by pr-preview bot Loading

netlify bot commented Jan 9, 2025 • edited Loading

✅ Deploy Preview for wai-aria ready!

pkra commented Jan 9, 2025

pkra commented Jan 9, 2025

pkra commented Jan 10, 2025

pkra commented Jan 23, 2025

pkra commented Jan 23, 2025

jnurthen commented Jan 23, 2025

pkra commented Feb 12, 2025

pkra commented Feb 13, 2025

spectranaut left a comment

Choose a reason for hiding this comment

spectranaut Feb 13, 2025

Choose a reason for hiding this comment

pkra Feb 14, 2025

Choose a reason for hiding this comment

pkra commented Feb 13, 2025

pkra commented Feb 14, 2025

pkra commented Jan 9, 2025 •

edited by pr-preview bot

Loading

netlify bot commented Jan 9, 2025 •

edited

Loading