Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restrict AT release dates to after 1999 #1308

Merged
merged 5 commits into from
Feb 3, 2025
Merged

fix: restrict AT release dates to after 1999 #1308

merged 5 commits into from
Feb 3, 2025

Conversation

outofambit
Copy link
Contributor

@outofambit outofambit commented Jan 28, 2025 •
edited
Loading

Updates validation for the date entry field used in the add and update AT releases UI to validate that the entered date is after the year 1999.

related to w3c/aria-at#1175

@outofambit outofambit marked this pull request as ready for review January 30, 2025 18:10
@outofambit outofambit requested a review from howard-e January 30, 2025 18:12
@outofambit outofambit mentioned this pull request Jan 30, 2025
Closed
howard-e
howard-e approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@howard-e howard-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for patching this up!

@outofambit a more appropriate error message may be better received for the modal now? Like Please enter a valid date (after December 31, 1999) or similar. I don't feel strongly on that phrasing but any thoughts?

@howard-e howard-e changed the title restrict AT release dates to after 1999 fix: restrict AT release dates to after 1999 Feb 3, 2025
@outofambit
Copy link
Contributor Author

Thanks @howard-e! Good point. I paraphrased something to make the message a little more descriptive.

@outofambit outofambit merged commit c5e591b into development Feb 3, 2025
2 checks passed
@outofambit outofambit deleted the minimum-release-year-validation branch February 3, 2025 22:09
@howard-e
Copy link
Contributor

howard-e commented Feb 3, 2025

Thanks @howard-e! Good point. I paraphrased something to make the message a little more descriptive.

Looks good, thanks!

@howard-e howard-e mentioned this pull request Feb 4, 2025
Merged
howard-e added a commit that referenced this pull request Feb 5, 2025
@howard-e
Merge pull request #1311 from w3c/development
8fd97e7 
Create February 4, 2025 Release

Includes the following changes:
* #1302
* #1303
* #1300, addresses #1270
* #1301, addresses #759 (additional documentation to follow)
* #1281, addresses #1241
* #1307
* #1308, addresses w3c/aria-at#1175
* #1309
* #1288, addresses #1253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howard-e howard-e howard-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@outofambit @howard-e @stalgiag