Add code review fixes

w3c · Nov 21, 2023 · 5a6072f · 5a6072f
1 parent 85ac89a
commit 5a6072f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/client/components/TestQueueRow/index.jsx b/client/components/TestQueueRow/index.jsx
@@ -414,9 +414,9 @@ const TestQueueRow = ({
             'completed'
         ].join('-');
 
-    const completedAllTests = !testPlanReport.draftTestPlanRuns.find(
+    const completedAllTests = testPlanReport.draftTestPlanRuns.every(
         testPlanRun =>
-            testPlanRun.testResultsLength !== testPlanReport.runnableTestsLength
+            testPlanRun.testResultsLength === testPlanReport.runnableTestsLength
     );
 
     return (

diff --git a/server/migrations/20231031162340-verifyNoSkippedTests.js b/server/migrations/20231031162340-verifyNoSkippedTests.js
@@ -38,13 +38,9 @@ module.exports = {
             });
 
             for (const data of Object.values(dataById)) {
-                let isComplete = true;
-
-                data.runLengths.forEach(runLength => {
-                    if (runLength !== data.runnableTestsLength) {
-                        isComplete = false;
-                    }
-                });
+                const isComplete = data.runLengths.every(
+                    runLength => runLength === data.runnableTestsLength
+                );
                 if (!isComplete) {
                     console.info(`Found incomplete report ${data.id}`); // eslint-disable-line
                     // Since final test plan reports can

diff --git a/server/scripts/populate-test-data/populateFakeTestResults.js b/server/scripts/populate-test-data/populateFakeTestResults.js
@@ -148,6 +148,10 @@ const populateFakeTestResults = async (testPlanRunId, fakeTestResultTypes) => {
         index += 1;
     }
 
+    // The following makes it so that fake tests are made for
+    // all possible tests that can be completed for any given
+    // test plan. Therefore, there will be no missing or skipped
+    // fake tests in the database.
     if (testPlanReport.runnableTests.length !== fakeTestResultTypes.length) {
         for (let i = index; i < testPlanReport.runnableTests.length; i += 1) {
             await getFake({