Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scribe-tool: Add button to download audio #27

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

rhiaro
Copy link
Member

@rhiaro rhiaro commented Dec 1, 2020

The button is available when a date with a valid IRC meeting log is present, and disabled otherwise. It uses the date to complete the URL to the ogg file, and just opens it in a new tab. This can then be saved easily from the browser (ctrl+s, etc).

Towards #23

Screenshot at 2020-12-01 20-10-02

@rhiaro rhiaro requested review from wyc, kimdhamilton and vsnt December 1, 2020 20:11
Copy link
Contributor

@kimdhamilton kimdhamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@kimdhamilton
Copy link
Contributor

ping @wyc and @vsnt to submit review

@wyc
Copy link
Contributor

wyc commented Dec 3, 2020

LGTM! Taking us out of the 1970s....

@vsnt
Copy link
Contributor

vsnt commented Dec 3, 2020

Very cool. What does the disabled state look like?

Edit: I would hope that when the "download audio" button is disabled, the button remains, but shows the feature is not available & maybe why. It would be confusing to have the button show up for some files and not on others without an explanation why.

@rhiaro
Copy link
Member Author

rhiaro commented Dec 4, 2020

@vsnt it is there but greyed out and unclickable. It is disabled when there are no minutes, but isn't smart enough to detect the state when there are minutes but for some reason the audio file is missing (in that case it'd open the audio link that matches the minutes, but then say 404 file not found). I'll open an issue about that; off the top of my head I'm not sure how I'd do that in a lightweight way with javascript.

Screenshot at 2020-12-04 10-03-45

@vsnt
Copy link
Contributor

vsnt commented Dec 4, 2020

Thanks for the details @rhiaro. That sounds satisfactory to me. I agree on opening an issue, but this does not need to be high priority or even ever addressed, just to track. And let's be sure to note this in the minutes instructions as well. (Not sure who is updating those.)

@rhiaro rhiaro merged commit 2fc3735 into w3c-ccg:gh-pages Dec 10, 2020
@rhiaro rhiaro deleted the feat-audio-dl branch December 10, 2020 20:20
msporny pushed a commit that referenced this pull request Aug 14, 2021
scribe-tool: Add button to download audio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants