moved try-catch inside removePosition

vzdc-artcc · Feb 11, 2025 · 31774b3 · 31774b3
1 parent fc97c91
commit 31774b3
Showing 1 changed file with 14 additions and 11 deletions.
diff --git a/bot.js b/bot.js
@@ -101,17 +101,24 @@ const clearRatings = async (client) => {
 }
 
 const removePosition = async (client) => {
-  const clientDbid = client.propcache.clientDatabaseId;
-  const serverGroupsById = await teamspeak.serverGroupsByClientId(clientDbid);
+  try{
+    const clientDbid = client.propcache.clientDatabaseId;
+
+    const serverGroupsById = await teamspeak.serverGroupsByClientId(clientDbid);
 
-  const positionToDelete = serverGroupsById.find((item) => item.name.includes("_"));
+    const positionToDelete = serverGroupsById.find((item) => item.name.includes("_"));
 
-  if(positionToDelete){
-    await teamspeak.serverGroupDelClient(clientDbid, positionToDelete.sgid);
-    await teamspeak.serverGroupDel(positionToDelete.sgid);
+    if(positionToDelete){
+      await teamspeak.serverGroupDelClient(clientDbid, positionToDelete.sgid);
+      await teamspeak.serverGroupDel(positionToDelete.sgid);
+    }
+  }catch(err){
+    console.log("error in removePosition")
+    console.log(err);
   }
 }
 
+
 teamspeak.on("ready", async () => {
   positionUpdate();
   setInterval(positionUpdate,60*1000);
@@ -234,11 +241,7 @@ teamspeak.on("clientconnect", async (connected) => {
 
 teamspeak.on("clientdisconnect", async (connected) => {
   const client = connected.client;
-  try{
-    removePosition(client);
-  }catch(err){
-    console.log(err);
-  }
+  removePosition(client);
 });
 
 teamspeak.on("close", async () => {