refactor[lang]: remove VyperNode __hash__() and __eq__() implementations
#4433
+43
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is a performance and correctness footgun for the hash and eq implementations to recurse. for instance, two nodes from different source files should never compare equal (you can use deepequals to signal intention there). this commit temporarily overrides the `__ne__` implementation for VyperNode so that we can find all the `!=` uses in the tests.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
since we no longer need to worry about __hash__ and __eq__performance
charles-cooper
changed the title
__hash__() and __eq__() implementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is a performance and correctness footgun for the hash and eq implementations to recurse. for instance, two nodes from different source files should never compare equal (you can use deepequals to signal intention there).
i refactored the test suite by temporarily overriding the
__ne__implementation for VyperNode so that we can find all the!=uses in the tests. the CI for this commit (0a9830b) passes (run https://github.com/vyperlang/vyper/actions/runs/12574333551/), and the training wheels are taken off in commit 71726ad.What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture