LCP: enable by default route-no-paths

[sever-sever]

Change Summary

LCP: enable by default route-no-paths

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Other (please describe):

Related Task(s)

Related PR(s)

Proposed changes

How to test

SMOKETEST

vyos@r14:~$ /usr/libexec/vyos/tests/smoke/cli/test_vpp.py
test_01_vpp_basic (__main__.TestVPP.test_01_vpp_basic) ... ok
test_02_vpp_vxlan (__main__.TestVPP.test_02_vpp_vxlan) ... ok
test_03_vpp_gre (__main__.TestVPP.test_03_vpp_gre) ... ok
test_04_vpp_geneve (__main__.TestVPP.test_04_vpp_geneve) ... skipped 'Skipping this test geneve index always is 0'
test_05_vpp_loopback (__main__.TestVPP.test_05_vpp_loopback) ... ok
test_06_vpp_bonding (__main__.TestVPP.test_06_vpp_bonding) ... ok
test_07_vpp_bridge (__main__.TestVPP.test_07_vpp_bridge) ... ok
test_08_vpp_ipip (__main__.TestVPP.test_08_vpp_ipip) ... ok
test_09_vpp_xconnect (__main__.TestVPP.test_09_vpp_xconnect) ... ok

----------------------------------------------------------------------
Ran 9 tests in 129.322s

OK (skipped=1)
vyos@r14:~$ 

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly

[dmbaturin]

I can't find the docs for that option in the VPP manual and from this help string, I'd never be able to guess what the option actually does.

Do you think it's possible to make it more descriptive?

If you point me at the docs, I can also think about it, once I know what it does. :)

[sever-sever]

I can't find the docs for that option in the VPP manual and from this help string, I'd never be able to guess what the option actually does.

It was added from the patch

The most suitable option learn-kernel-routes < enable|disable >

What do you think about it?

[dmbaturin]

learn-kernel-routes sounds good to me! Although we made an agreement long ago that we do not create nodes with arguments like true/false, enable/disable, etc.

If you think the most sensible default is to have the dataplane learn kernel routes, then we should have a valueless node like disable-learning-kernel-routes (or similar, e.g., ignore-kernel-routes).

If you think the default should be not to learn then, we should add a valueless node learn-kernel-routes.

[sever-sever]

Done!

set vpp settings lcp ignore-kernel-routes