Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T6912: Fix build package script dependencies #845

Merged
merged 4 commits into from
Nov 26, 2024
Merged

T6912: Fix build package script dependencies #845

merged 4 commits into from
Nov 26, 2024

Conversation

sever-sever
Copy link
Member

@sever-sever sever-sever commented Nov 25, 2024 •
edited
Loading

Change Summary

Install dependencies declared in the package.toml file does not work due to the wrong logic.
Set global dependencies instead of dependencies per package.

Fix dependencies for FRR
Fix dependencied for TACACS

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

build

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@sever-sever
T6912: Fix build package script dependencies
aa40b27 
Install dependencies declared in the package.toml file does not
work due to the wrong logic. Set global dependencies instaed of
dependencies per package.
@sever-sever
T6912: Build FRR use global dependencies
3b786bf
@sever-sever
T6912: Build TACACS use global dependencies
3bbcbb6
@sever-sever sever-sever requested a review from a team as a code owner November 25, 2024 14:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

👍
No issues in PR Title / Commit Title

@github-actions github-actions bot added the current VyOS rolling release label Nov 25, 2024
@c-po c-po merged commit dcf1d92 into vyos:current Nov 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-po c-po c-po approved these changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin was automatically assigned from vyos/reviewers

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev was automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc was automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro was automatically assigned from vyos/reviewers

@nicolas-fort nicolas-fort Awaiting requested review from nicolas-fort nicolas-fort was automatically assigned from vyos/reviewers

Assignees

@sever-sever sever-sever

Labels
current VyOS rolling release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sever-sever @c-po