Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(TF-410): multibrand ci/cd #7401
docs(TF-410): multibrand ci/cd #7401
Changes from 5 commits
288d752
a35ad2b
6684651
53f5377
6f44a36
45a8fd2
b140bed
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having all the steps listed here and explained briefly would be nice. An image visualizing this would be superb ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided with @mateuszo that the points above this one are too detailed and we should keep them internally for our team. It could indeed make it much easier to leave Alokai.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So should then make a CI workflow a blackbox? Right now, all the code, which I describe here, will be delivered to the customer anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to ensure that you understand that the client will still receive this code, so if necessary it can be migrated when they understand it. Unless it’s us who don’t understand the case you’re referring to, in which case that’s fine. In any event, we just want confirmation that we are all on the same page and understand the consequences both of removing this from the docs and that the client still receives this code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with keeping the code white-boxed. I hope that the consequences of leaving this part undocumented would be that nobody touches that.
Anyway, I don't have a strong opinion on removing this. It just makes the feature look more complex and non-service-like to me ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can black-box it later on, for now this seems to be an easy fix for what @mateuszo raised. Let's keep it on confluence tho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I removed the CI part and moved it to the Confluence