Allow scrollBehavior selectors to match ids with unescaped CSS special characters (feature request #3008) #3009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously a scrollBehavior selector was only checked for ^#\d when determining whether to use getElementById or querySelector for matching; this would not work as intended for chained queries (e.g. `vuejs#9, .main`) or those with CSS special characters (e.g. `#one/two`).
posva
reviewed
Oct 24, 2019
| @@ -121,14 +121,16 @@ function isNumber (v: any): boolean { | |||
| return typeof v === 'number' | |||
| } | |||
|
|
|||
| const hashStartsWithNumberRE = /^#\d/ | |||
| const selectorLooksLikeIdRE = /^#[^, ]+$/ | |||
There was a problem hiding this comment.
@posva a , or suggests a complex selector (either nested or an OR). Technically an id selector could contain an , but the above provides the best balance of simplicity vs. coverage without breaking changes. Consider:
// Simple selector (passed to getElementById):
#one
#1
#one/two
// Complex selector (passed to querySelector):
#one .two
#one, .two
#one\,two // selects id="one,two"
Did you have any suggestions?
There was a problem hiding this comment.
Hi @posva any update on this PR?
|
Thanks for this but I think we need to go in a different direction: #3008 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the title and the original feature request #3008 this PR means a wider range of selectors are passed to
document.getElementById, resulting in more straightforward use ofscrollBehaviorwith e.g.to.hash