docs(guide/components/slots): clarify slot presence phrasing #3124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original phrasing "whether or not a slot is present" was potentially misleading, as it suggested checking the existence of the slot itself rather than whether content was passed to it. Updated the explanation to clarify this distinction for better readability and accuracy.
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Oh, I just noticed another related phrase right below the one I addressed in this PR: The phrase "When the header/footer/default is present..." could also be interpreted as referring to the slot's definition, rather than whether content is provided for the slot. A clearer alternative: Let me know if I should open another PR for this. |
|
You shouldn't open a new PR. Make a new commit into this one. The proposed change is adressing the same thing. |
The phrase "When the header/footer/default is present..." could be interpreted as referring to the slot's definition, rather than whether content is provided for the slot
done. Thanks |
NataliaTepluhina
approved these changes
Dec 9, 2024
szymonlicau
pushed a commit
to monterail/vue3-docs-pl
that referenced
this pull request
Dec 9, 2024
) * docs(guide/components/slots): clarify slot presence phrasing The original phrasing "whether or not a slot is present" was potentially misleading, as it suggested checking the existence of the slot itself rather than whether content was passed to it. Updated the explanation to clarify this distinction for better readability and accuracy. * docs(guide/components/slots): clarify slot presence phrasing (2) The phrase "When the header/footer/default is present..." could be interpreted as referring to the slot's definition, rather than whether content is provided for the slot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
The original phrasing "whether or not a slot is present" was potentially misleading, as it suggested checking the existence of the slot itself rather than whether content was passed to it. Updated the explanation to clarify this distinction for better readability and accuracy.
Proposed Solution
The original phrase was replaced with "...whether or not content has been passed to a slot"
Additional Information