Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix themes #2939

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Fix themes #2939

merged 3 commits into from
Jul 19, 2024

Conversation

AloisSeckar
Copy link
Contributor

Description of Problem

In #2896 two problems were introduced.

  1. The trailing comma at the end of the .json file broke the page completely:
    image

  2. Orphaned link with no markdown
    image

Proposed Solution

Little adjustments to fix it

Additional Information

(I am sorry for two extra commits in this PR. Apparently I put my latest fix into main instead of a separate branch.)

Copy link

netlify bot commented Jul 18, 2024

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 9ceb100
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/6698c99fb7119e00087b0d65
😎 Deploy Preview https://deploy-preview-2939--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yyx990803 yyx990803 merged commit 8603114 into vuejs:main Jul 19, 2024
5 checks passed
@AloisSeckar AloisSeckar deleted the fix-themes branch July 19, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants