-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add vue 2 nes banner #2581
add vue 2 nes banner #2581
Conversation
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for the PR @leonibr! I'm not sure where the approval from this is coming from, so I've requested Evan as the reviewer for this, but if you can provide additional context (you can reach via Discord or Twitter if it helps), I can try to help expedite this! |
Great, @bencodezen, I am from Herodevs, a Vue partner company that provides Vue 2 Never-ending-support, I believe Evan is the right one to review this since he was the one providing instructions to our marketing team of where and how to do it. |
@bencodezen hey there! I am on the HeroDevs team as well and have been working with @yyx990803 on this project. I wanted to echo your thoughts about having Evan as the reviewer, I think that is great as we can keep the conversation going. @leonibr thank you for getting this ready for review! |
I've removed the config change. Vue School banner injection has already been toggled off from their side. |
Thank you Evan! Excited to see it on the site!
…On Thu, Nov 30, 2023 at 9:33 PM Evan You ***@***.***> wrote:
I've removed the config change. Vue School banner injection has already
been toggled off from their side.
—
Reply to this email directly, view it on GitHub
<#2581 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6CXP2WRLT6PIJZU625FMMDYHFM3PAVCNFSM6AAAAAA7544M5GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZVGQ2DENZRGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
This reverts commit 662c7da.
Description of Problem
Add the approved banner of Vue 2 NES
Proposed Solution
Replaced the existent Banner component code to accommodate the changes
Additional Information