Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vue 2 nes banner #2581

Merged
merged 3 commits into from
Dec 1, 2023
Merged

add vue 2 nes banner #2581

merged 3 commits into from
Dec 1, 2023

Conversation

leonibr
Copy link
Contributor

@leonibr leonibr commented Nov 28, 2023

Description of Problem

Add the approved banner of Vue 2 NES

Proposed Solution

Replaced the existent Banner component code to accommodate the changes

Additional Information

⚠️ I removed the code from active banner which is injected from vue school website

Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 9d5d900
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/6569636da4c97f00087eab38
😎 Deploy Preview https://deploy-preview-2581--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bencodezen bencodezen requested a review from yyx990803 November 29, 2023 17:18
@bencodezen
Copy link
Member

Thanks for the PR @leonibr! I'm not sure where the approval from this is coming from, so I've requested Evan as the reviewer for this, but if you can provide additional context (you can reach via Discord or Twitter if it helps), I can try to help expedite this!

@bencodezen bencodezen added the state: awaiting-feedback Needs more input before further actions can be taken label Nov 29, 2023
@leonibr
Copy link
Contributor Author

leonibr commented Nov 29, 2023

Great, @bencodezen, I am from Herodevs, a Vue partner company that provides Vue 2 Never-ending-support, I believe Evan is the right one to review this since he was the one providing instructions to our marketing team of where and how to do it.

@jwcalles
Copy link

@bencodezen hey there! I am on the HeroDevs team as well and have been working with @yyx990803 on this project. I wanted to echo your thoughts about having Evan as the reviewer, I think that is great as we can keep the conversation going. @leonibr thank you for getting this ready for review!

@yyx990803
Copy link
Member

I've removed the config change. Vue School banner injection has already been toggled off from their side.

@jwcalles
Copy link

jwcalles commented Dec 1, 2023 via email

@yyx990803 yyx990803 merged commit 662c7da into vuejs:main Dec 1, 2023
5 checks passed
yyx990803 added a commit that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: awaiting-feedback Needs more input before further actions can be taken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants