fix(tutorial): race condition on step-10 #2567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
NataliaTepluhina
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
@ubugeeei thank you! I think this is the cleanest way to handle the race condition here
nazarepiedady
pushed a commit
to nazarepiedady/vue3-docs
that referenced
this pull request
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
In the code for step 10 of the tutorial, there is an issue where rapidly clicking the button can result in the results not matching the id.
Proposed Solution
There are several possible solutions.
As referred to in #2537, adding a cleanup process would require explaining more, which I'm concerned might deviate from the original purpose.
Therefore, I believe one of the first two options mentioned would be preferable.
In this PR, I tried fixing it in the direction of disabling the button, as initially suggested!
Behavior after the correction:
2023-11-13.23.56.50.mov
Additional Information
If you have any better suggestions for the fix, please feel free to propose them! 😄