New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use ts files when necessary with --bare option #653

Merged

haoqunjiang merged 1 commit into vuejs:main from cexbrayat:fix/bare-typescript

Jan 8, 2025

Member

cexbrayat commented Jan 2, 2025

Description

With v3.13.0, the generated tests were using the .js extension. See https://github.com/vuejs/create-vue-templates/tree/v3.13.0/bare-typescript-vitest/src/__tests__ for example

We now render all files before renaming them with the .ts extension if needed.


          fix: use ts files when necessary with --bare option

370819f

With v3.13.0, the generated tests were using the `.js` extension.
See https://github.com/vuejs/create-vue-templates/tree/v3.13.0/bare-typescript-vitest/src/__tests__ for example

We now render all files _before_ renaming them with the .ts extension if needed.

cexbrayat requested a review from haoqunjiang

January 7, 2025 16:34

haoqunjiang approved these changes

View reviewed changes

haoqunjiang merged commit f5291af into vuejs:main

52 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet