Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useTemplateRef): don't update setup ref for useTemplateRef key #12756

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+41 −8
Open

fix(useTemplateRef): don't update setup ref for useTemplateRef key #12756

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1dff446
fix(useTemplateRef): don't update setup ref for useTemplateRef key
edison1105 Jan 21, 2025
3a16ebc
chore: update
edison1105 Jan 21, 2025
0d9a8cb
Update packages/runtime-core/src/helpers/useTemplateRef.ts
edison1105 Jan 21, 2025
0cc0137
[autofix.ci] apply automated fixes
autofix-ci[bot] Jan 21, 2025
b9cd226
chore: minor tweaks
edison1105 Jan 21, 2025
e4208e4
test: add tests
edison1105 Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update packages/runtime-core/src/helpers/useTemplateRef.ts 
Co-authored-by: Jacek Karczmarczyk <jkarczm@gmail.com>
@edison1105 @jacekkarczmarczyk
edison1105 and jacekkarczmarczyk authored Jan 21, 2025
commit 0d9a8cb62569438ca37f3f12b538e9e0d3832008
8 changes: 1 addition & 7 deletions packages/runtime-core/src/helpers/useTemplateRef.ts
View file
Original file line number Diff line number Diff line change
@@ -36,12 +36,6 @@ export function useTemplateRef<T = unknown, Keys extends string = string>(

export function isUseTemplateRefKey(refs: Data, key: string): boolean {
let desc: PropertyDescriptor | undefined
if (
(desc = Object.getOwnPropertyDescriptor(refs, key)) &&
return (desc = Object.getOwnPropertyDescriptor(refs, key)) &&
!desc.configurable
) {
return true
}

return false
}