Add new custom resource: elasticsearch.IngestPipeline #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm missing the authentication part: It looks like you just do an unauthenticated HTTP request? |
benbridts
reviewed
Sep 1, 2021
custom_resources/elasticsearch.py
Outdated
| "Version": "2012-10-17", | ||
| "Statement": [{ | ||
| "Effect": "Allow", | ||
| "Action": "es:ESHttp*", |
There was a problem hiding this comment.
I think we can scope this down more (definitely for action, possibly for resource)
There was a problem hiding this comment.
I added commit: cf0b80f which only allows ESHttpPut and ESHttpDelete
|
Putting this PR on hold for now: From version 7.13+ Filebeat will only work with the Elasticsearch distribution from Elastic as it will now check the license, at least at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a new custom resource: elasticsearch.IngestPipeline.
Ingest pipelines let you perform common transformations on your data before indexing. For example, you can use pipelines to remove fields, extract values from text, and enrich your data.