Skip to content

Commit

Permalink
leftovers,NFC
Browse files Browse the repository at this point in the history
  • Loading branch information
toxieainc committed Jan 13, 2025
1 parent e62f20f commit 7915412
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/wpc/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -2827,7 +2827,7 @@ void core_update_pwm_outputs(const int startIndex, const int count)
UINT8 col = 0;
for (int j = 0; j < 8; j++)
if (coreGlobals.physicOutputState[CORE_MODOUT_LAMP0 + i * 8 + j].value >= 0.1f)
col |= 1 << j;
col |= (UINT8)1 << j;
coreGlobals.lampMatrix[i] = col;
}
}
Expand All @@ -2836,7 +2836,7 @@ void core_update_pwm_outputs(const int startIndex, const int count)
UINT32 sols = 0;
for (int i = 0; i < 32; i++)
if (coreGlobals.physicOutputState[CORE_MODOUT_SOL0 + i].value >= 0.5f)
sols |= 1 << i;
sols |= 1u << i;
coreGlobals.solenoids = sols;
}
}
Expand Down
1 change: 1 addition & 0 deletions src/wpc/dedmd.c
Original file line number Diff line number Diff line change
Expand Up @@ -562,6 +562,7 @@ static WRITE_HANDLER(dmd16_ctrl_w) {
}

static void dmd16_updbusy(int evt) {
//const int prev_busy = dmdlocals.busy;
// TODO CLR_PULSE will reset the flip flop to 0 even while PRESET is pulled down. This does not match the datasheet which states
// that in this situation both output would be high (so keep BUSY at 1, but also trigger INT1).
if (evt == BUSY_CLR_PULSE)
Expand Down
2 changes: 1 addition & 1 deletion src/wpc/sam.c
Original file line number Diff line number Diff line change
Expand Up @@ -1413,7 +1413,7 @@ static MACHINE_INIT(sam) {
core_set_pwm_output_type(CORE_MODOUT_LAMP0 + 100, 6, CORE_MODOUT_LED); // Ramp RGB LEDs
core_set_pwm_output_type(CORE_MODOUT_SOL0 + 17 - 1, 5, CORE_MODOUT_BULB_89_20V_DC_WPC);
core_set_pwm_output_type(CORE_MODOUT_SOL0 + 25 - 1, 8, CORE_MODOUT_BULB_89_20V_DC_WPC);
if (rootDrv->name[strlen(rootDrv->name)-1] == 'h')
if (gn[strlen(gn)-1] == 'h')

This comment has been minimized.

Copy link
@vbousquet

vbousquet Jan 13, 2025

Contributor

gn is the root driver. I think this defeat the purpose to adapt to the actual driver between pro/LE

This comment has been minimized.

Copy link
@toxieainc

toxieainc Jan 13, 2025

Author Member

The change is equivalent, see line 1271. So if something else was intended, then it was also wrong before. ;)

This comment has been minimized.

Copy link
@vbousquet

vbousquet Jan 13, 2025

Contributor

Yeah, my bad, should have been Machine not rootDrv. I will commit a fix

core_set_pwm_output_type(CORE_MODOUT_LAMP0, 80, CORE_MODOUT_LED_STROBE_1_10MS); // Limited Edition: All LED
else
core_set_pwm_output_type(CORE_MODOUT_LAMP0 + 60 - 1, 3, CORE_MODOUT_LED_STROBE_1_10MS); // Pro: #555 except for bumper LEDs
Expand Down

3 comments on commit 7915412

@Tom-Neverwinter
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nfc?

@volkenborn
Copy link
Contributor

@volkenborn volkenborn commented on 7915412 Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No Further Comments.

I also like "Noone fricking cares" 🤣

@toxieainc
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No functional change

Please sign in to comment.