-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Isolate and abstract three.js related code. #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the right material.
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
========================================
+ Coverage 90.2% 90.6% +0.4%
========================================
Files 155 158 +3
Lines 10011 9938 -73
Branches 1156 1125 -31
========================================
- Hits 9027 8998 -29
+ Misses 610 570 -40
+ Partials 374 370 -4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR abstracts render-related code into an interface that can be implemented by other WebGL frameworks. The main goal is to be able to tree-shake non-used render code (and specially three.js) in case another WebGL framework is used.
Future candidates for render support are Babylon.js, PlayCanvas and maybe Google's Filament.
There are still a few quirks that probably will need to be resolved once support for another renderer is added: