Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ruby 3.4 support #158

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Add Ruby 3.4 support #158

merged 2 commits into from
Jan 24, 2025

Conversation

bastelfreak
Copy link
Member

This is based on the new composable action https://github.com/voxpupuli/ruby-version

@bastelfreak bastelfreak self-assigned this Jan 24, 2025
ekohl
ekohl reviewed Jan 24, 2025
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@bastelfreak bastelfreak force-pushed the matrix branch 6 times, most recently from c3dc01b to 1337148 Compare January 24, 2025 15:40
ekohl
ekohl reviewed Jan 24, 2025
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
@bastelfreak bastelfreak force-pushed the matrix branch 3 times, most recently from b222ad1 to 43ca3d4 Compare January 24, 2025 16:42
ekohl
ekohl reviewed Jan 24, 2025
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
ekohl
ekohl approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the changelog I think we should say this adds Ruby 3.4 support. The dynamic matrix building is less important for users.

@bastelfreak bastelfreak changed the title CI: Build ruby matrix dynamically Add Ruby 3.4 support Jan 24, 2025
@bastelfreak bastelfreak merged commit b16a01b into voxpupuli:master Jan 24, 2025
8 checks passed
@bastelfreak bastelfreak deleted the matrix branch January 24, 2025 16:51
@ekohl ekohl added the enhancement New feature or request label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstraw jstraw jstraw approved these changes

@ekohl ekohl ekohl approved these changes

Assignees

@bastelfreak bastelfreak

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bastelfreak @ekohl @jstraw