Add varnish pid file path configuration option #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvangestel
force-pushed
the
feature/pid-file
branch
from
91363a3 to
7dd1d59
Compare
|
@vvangestel thanks, could you please also add some tests |
|
Hello, I've added the requested tests. Can you check again to see if they match expectations? |
|
Hi, I will have a look at it soon. The test itself ist ok for me. Just I was not 100% sure if the change of the config has any impact with systemdconfig. So I wanted to test that before merging |
|
Can this PR be merged & released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Adds an additional configuration option to set the PID file path. If
undef(default) no change is made. Useful for stability/consistency.This Pull Request (PR) fixes the following issues
Fixes an issue when the default file path is incompatible with the system and needs to be reconfigured.