Fix remaining rubocop offenses

lib/puppet/type/splunk_config.rb

@@ -10,6 +10,7 @@
     desc 'splunk config'
   end
 
+  # rubocop:disable Lint/EmptyBlock
   newparam(:forwarder_installdir) do
   end
 
@@ -21,6 +22,7 @@
 
   newparam(:server_confdir) do
   end
+  # rubocop:enable Lint/EmptyBlock
 
   ## Generate purge parameters for the splunk_config type
   %i[

spec/classes/splunk_spec.rb

@@ -3,21 +3,17 @@
 require 'spec_helper'
 
 describe 'splunk' do
-  context 'supported operating systems' do
-    on_supported_os.each do |os, facts|
-      if os.start_with?('windows')
-        # Splunk Server not used supported on windows
-      else
-        context "on #{os}" do
-          let(:facts) do
-            facts
-          end
+  on_supported_os.each do |os, facts|
+    next if facts[:os]['name'] == 'windows' # Splunk Server not used supported on windows
 
-          context 'splunk class without any parameters' do
-            it { is_expected.to compile.with_all_deps }
-            it { is_expected.to contain_class('splunk') }
-          end
-        end
+    context "on #{os}" do
+      let(:facts) do
+        facts
+      end
+
+      context 'splunk class without any parameters' do
+        it { is_expected.to compile.with_all_deps }
+        it { is_expected.to contain_class('splunk') }
       end
     end
   end

spec/defines/addon_spec.rb

@@ -5,18 +5,16 @@
 describe 'splunk::addon' do
   context 'fail if class prerequisit not declared' do
     on_supported_os.each do |os, facts|
-      if os.start_with?('windows')
-        # Splunk Server not used supported on windows
-      else
-        context "on #{os}" do
-          let(:facts) do
-            facts
-          end
-          let(:title) { 'Splunk_TA' }
-          let(:params) { { 'splunkbase_source' => 'puppet:///modules/profiles/splunk-add-on.tgz' } }
-
-          it { is_expected.to compile.and_raise_error(%r{Error while evaluating a Function Call}) }
+      next if facts[:os]['name'] == 'windows' # Splunk Server not used supported on windows
+
+      context "on #{os}" do
+        let(:facts) do
+          facts
         end
+        let(:title) { 'Splunk_TA' }
+        let(:params) { { 'splunkbase_source' => 'puppet:///modules/profiles/splunk-add-on.tgz' } }
+
+        it { is_expected.to compile.and_raise_error(%r{Error while evaluating a Function Call}) }
       end
     end
   end
@@ -27,18 +25,16 @@
     end
 
     on_supported_os.each do |os, facts|
-      if os.start_with?('windows')
-        # Splunk Server not used supported on windows
-      else
-        context "on #{os}" do
-          let(:facts) do
-            facts
-          end
-          let(:title) { 'Splunk_TA' }
-          let(:params) { { 'splunkbase_source' => 'puppet:///modules/profiles/splunk-add-on.tgz' } }
-
-          it { is_expected.to compile.with_all_deps }
+      next if facts[:os]['name'] == 'windows' # Splunk Server not used supported on windows
+
+      context "on #{os}" do
+        let(:facts) do
+          facts
         end
+        let(:title) { 'Splunk_TA' }
+        let(:params) { { 'splunkbase_source' => 'puppet:///modules/profiles/splunk-add-on.tgz' } }
+
+        it { is_expected.to compile.with_all_deps }
       end
     end
   end

spec/unit/puppet/type/splunk_config_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe Puppet::Type.type(:splunk_config) do
-  let(:subject) do
+  let(:subject) do # rubocop:disable RSpec/SubjectDeclaration
     described_class.new(
       name: 'config',
       server_confdir: '/opt/splunk/etc',