Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rules::ospf3 & rules::out::ospf3: Allow filtering on outgoing interfaces #234

Merged
merged 2 commits into from
Dec 31, 2023
Merged

rules::ospf3 & rules::out::ospf3: Allow filtering on outgoing interfaces #234

merged 2 commits into from
Dec 31, 2023

Conversation

bastelfreak
Copy link
Member

Also contains #233

@bastelfreak bastelfreak added the enhancement New feature or request label Dec 31, 2023
@bastelfreak bastelfreak self-assigned this Dec 31, 2023
smortex
smortex approved these changes Dec 31, 2023
View reviewed changes
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That also look reasonable. Maybe adding tests could help if the syntax ever change?

@bastelfreak bastelfreak force-pushed the ospf branch 2 times, most recently from 3798818 to 1b1b1a3 Compare December 31, 2023 13:04
@bastelfreak
Copy link
Member Author

added unit tests

@bastelfreak bastelfreak merged commit 9685362 into master Dec 31, 2023
29 checks passed
@bastelfreak bastelfreak deleted the ospf branch December 31, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex approved these changes

Assignees

@bastelfreak bastelfreak

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastelfreak @smortex