Update rpm provider to include AWS Linux #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specification of Linux osfamily may be too general, but this will have to get fixed as support for more operating systems is added. Here are some results to use: Debian: $ facter | egrep operatingsystem\|osfamily operatingsystem => Debian operatingsystemrelease => 7.8 osfamily => Debian AWS Linux: $ facter | egrep operatingsystem\|osfamily operatingsystem => Amazon operatingsystemrelease => 3.14.44-32.39.amzn1.x86_64 osfamily => Linux Issue: voxpupuli#25
|
|
|
I agree with @igalic, confining on :linux is likely to be overly broad. |
|
Hello: What's the status of this PR? |
|
Closing due to lack of response. Please reopen if still needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specification of Linux osfamily may be too general,
but this will have to get fixed as support for more operating
systems is added. Here are some results to use:
Debian:
$ facter | egrep operatingsystem|osfamily
operatingsystem => Debian
operatingsystemrelease => 7.8
osfamily => Debian
AWS Linux:
$ facter | egrep operatingsystem|osfamily
operatingsystem => Amazon
operatingsystemrelease => 3.14.44-32.39.amzn1.x86_64
osfamily => Linux
Issue: #25