Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we use the latest facter versions for each minor release #341

Merged
merged 1 commit into from
May 16, 2024

Conversation

bastelfreak
Copy link
Member

No description provided.

@yakatz
Copy link
Member

yakatz commented May 16, 2024

Should this be similar to #334 instead of hard-coded?

Of course, then there are two version files and it starts to look enticing to add some structure to it - should be simple enough to expand the existing regex

For example:

# Facter 4.7.0 - Released April 2024 and shipped with Puppet 8.6.0.
8.6.0:4.7.0

# Facter 4.6.1 - Released March 2024 and shipped with Puppet 8.5.1.
8.5.1:4.6.1

...

Regex: (?<puppet>^\d+\.\d+\.\d+)?\:(?<facter>^\d+\.\d+\.\d+)?

@bastelfreak
Copy link
Member Author

I'm not sure if that's worth the effort. for the AIO versions it made sense because there were stored multiple times in the sh script and in the ps1 script. The gem versions are currently only in get_facts.sh.

@yakatz
Copy link
Member

yakatz commented May 16, 2024

OK, we can always change it later if the scripts are split/updated

@bastelfreak bastelfreak merged commit f62300e into voxpupuli:master May 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants