Add aio_agent_version fact to 4.2 with fact missing #271
Conversation
choffee
force-pushed
the
aio_agent_version
branch
from
3921b2a to
ee3b26d
Compare
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "aio_agent_version": "7.20.0", | |||
There was a problem hiding this comment.
FreeBSD does not have AIO package.
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "aio_agent_version": "7.20.0", | |||
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "aio_agent_version": "7.20.0", | |||
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "aio_agent_version": "7.20.0", | |||
There was a problem hiding this comment.
@bastelfreak may confirm, but I am pretty sure ArchLinux does not have this fact for the same reason as FreeBSD: not an AIO package.
There was a problem hiding this comment.
correct, arch linux does not have it
There was a problem hiding this comment.
I think the root cause is that we use Facter, but aio_agent_version comes from Puppet's facts. No custom facts are included in FacterDB so I doubt this is correct.
In rspec-puppet-facts you could work around this with a dynamic custom fact: https://github.com/voxpupuli/rspec-puppet-facts#create-dynamic-facts
add_custom_fact :aio_agent_version, -> { |_os, facts| facts[:puppetversion] }Or make it more dynamic and filter out the OSes that actually ship AIO
|
outdated, needs rebase |
This should fix #270
This only adds it back to the 4.2 versions.