Purge custom facts

voxpupuli · Jun 12, 2024 · 50e9db7 · 50e9db7
1 parent 4ca326a
commit 50e9db7
Show file tree

Hide file tree

Showing 8 changed files with 49 additions and 398 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2024-06-10 08:58:13 UTC using RuboCop version 1.63.5.
+# on 2024-06-12 14:45:50 UTC using RuboCop version 1.63.5.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -71,14 +71,14 @@ RSpec/DescribedClass:
   Exclude:
     - 'spec/facter_db_spec.rb'
 
-# Offense count: 3
+# Offense count: 5
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
-  Max: 9
+  Max: 13
 
-# Offense count: 4
+# Offense count: 8
 RSpec/MultipleExpectations:
-  Max: 7
+  Max: 13
 
 # Offense count: 11
 # Configuration parameters: AllowSubject.
@@ -186,7 +186,7 @@ Style/SymbolProc:
   Exclude:
     - 'Rakefile'
 
-# Offense count: 4
+# Offense count: 5
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
 # URISchemes: http, https

diff --git a/facts/4.0/oraclelinux-7-x86_64.facts b/facts/4.0/oraclelinux-7-x86_64.facts
@@ -454,7 +454,6 @@
   "puppetversion": "7.5.0",
   "whereami": "pdx",
   "function": "",
-  "env_temp_variable": "/tmp",
   "haszfs": false,
   "ip6tables_version": "1.4.21",
   "mongodb_is_master": "not_installed",
@@ -570,12 +569,6 @@
   "platform_symlink_writable": true,
   "platform_tag": "el-7-x86_64",
   "jenkins_plugins": "",
-  "python_release": "2.7",
-  "python2_release": "2.7",
-  "puppet_ssldir": "/etc/puppetlabs/puppet/ssl",
-  "puppet_digest_algorithm": "sha256",
-  "puppet_config": "/etc/puppetlabs/puppet/puppet.conf",
-  "puppet_stringify_facts": false,
   "mco_confdir": "/etc/mcollective/etc",
   "os_maj_version": "7",
   "pper_installed": false,
@@ -594,105 +587,5 @@
   "lvm_vg_centos_pvs": "/dev/sda2",
   "lvm_pvs": 1,
   "lvm_pv_0": "/dev/sda2",
-  "puppet_agent_pid": 2569,
-  "python_version": "2.7.5",
-  "python2_version": "2.7.5",
-  "aio_agent_build": "7.4.1.59.g5d5199a8a",
-  "aio_agent_version": "7.4.1.59",
-  "docker_home_dirs": {
-    "root": "/root",
-    "bin": "/bin",
-    "daemon": "/sbin",
-    "adm": "/var/adm",
-    "lp": "/var/spool/lpd",
-    "sync": "/sbin",
-    "shutdown": "/sbin",
-    "halt": "/sbin",
-    "mail": "/var/spool/mail",
-    "operator": "/root",
-    "games": "/usr/games",
-    "ftp": "/var/ftp",
-    "nobody": "/",
-    "avahi-autoipd": "/var/lib/avahi-autoipd",
-    "systemd-bus-proxy": "/",
-    "systemd-network": "/",
-    "dbus": "/",
-    "polkitd": "/",
-    "rpc": "/var/lib/rpcbind",
-    "tss": "/dev/null",
-    "rpcuser": "/var/lib/nfs",
-    "nfsnobody": "/var/lib/nfs",
-    "postfix": "/var/spool/postfix",
-    "sshd": "/var/empty/sshd"
-  },
-  "prometheus_alert_manager_running": false,
-  "who2bug": [
-
-  ],
-  "classification": {
-    "hostname": "live-pulp",
-    "parts": [
-      "live",
-      "",
-      "",
-      "",
-      "pulp",
-      ""
-    ],
-    "version": 0,
-    "group": "live",
-    "function": "",
-    "number": "",
-    "number_string": "",
-    "context": "",
-    "stage": "pulp",
-    "id": ""
-  },
-  "group": "live",
-  "puppet_inventory_metadata": {
-    "packages": {
-      "collection_enabled": false,
-      "last_collection_time": "0.0s"
-    }
-  },
-  "function_number": "",
-  "virt_libvirt": false,
-  "stage": "pulp",
-  "mysql_server_id": 23179131,
-  "selinux_python_command": "python",
-  "is_pe": false,
-  "pe_patch": {
-    "package_updates": [
-
-    ],
-    "package_update_count": 0,
-    "missing_update_kbs": [
-
-    ],
-    "security_package_updates": [
-
-    ],
-    "security_package_update_count": 0,
-    "blackouts": {
-    },
-    "pinned_packages": [
-
-    ],
-    "last_run": {
-    },
-    "patch_group": "",
-    "reboot_override": "default",
-    "reboots": {
-      "reboot_required": "unknown"
-    },
-    "block_patching_on_warnings": "false",
-    "warnings": {
-      "update_file": "Update file not found, update information invalid",
-      "security_update_file": "Security update file not found, update information invalid"
-    },
-    "blocked": false,
-    "blocked_reasons": [
-
-    ]
-  }
+  "aio_agent_version": "7.4.1.59"
 }
diff --git a/facts/4.0/scientific-7-x86_64.facts b/facts/4.0/scientific-7-x86_64.facts
@@ -454,7 +454,6 @@
   "puppetversion": "7.5.0",
   "whereami": "pdx",
   "function": "",
-  "env_temp_variable": "/tmp",
   "haszfs": false,
   "ip6tables_version": "1.4.21",
   "mongodb_is_master": "not_installed",
@@ -570,12 +569,6 @@
   "platform_symlink_writable": true,
   "platform_tag": "el-7-x86_64",
   "jenkins_plugins": "",
-  "python_release": "2.7",
-  "python2_release": "2.7",
-  "puppet_ssldir": "/etc/puppetlabs/puppet/ssl",
-  "puppet_digest_algorithm": "sha256",
-  "puppet_config": "/etc/puppetlabs/puppet/puppet.conf",
-  "puppet_stringify_facts": false,
   "mco_confdir": "/etc/mcollective/etc",
   "os_maj_version": "7",
   "pper_installed": false,
@@ -593,106 +586,5 @@
   "lvm_vg_0": "centos",
   "lvm_vg_centos_pvs": "/dev/sda2",
   "lvm_pvs": 1,
-  "lvm_pv_0": "/dev/sda2",
-  "puppet_agent_pid": 2569,
-  "python_version": "2.7.5",
-  "python2_version": "2.7.5",
-  "aio_agent_build": "7.4.1.59.g5d5199a8a",
-  "aio_agent_version": "7.4.1.59",
-  "docker_home_dirs": {
-    "root": "/root",
-    "bin": "/bin",
-    "daemon": "/sbin",
-    "adm": "/var/adm",
-    "lp": "/var/spool/lpd",
-    "sync": "/sbin",
-    "shutdown": "/sbin",
-    "halt": "/sbin",
-    "mail": "/var/spool/mail",
-    "operator": "/root",
-    "games": "/usr/games",
-    "ftp": "/var/ftp",
-    "nobody": "/",
-    "avahi-autoipd": "/var/lib/avahi-autoipd",
-    "systemd-bus-proxy": "/",
-    "systemd-network": "/",
-    "dbus": "/",
-    "polkitd": "/",
-    "rpc": "/var/lib/rpcbind",
-    "tss": "/dev/null",
-    "rpcuser": "/var/lib/nfs",
-    "nfsnobody": "/var/lib/nfs",
-    "postfix": "/var/spool/postfix",
-    "sshd": "/var/empty/sshd"
-  },
-  "prometheus_alert_manager_running": false,
-  "who2bug": [
-
-  ],
-  "classification": {
-    "hostname": "live-pulp",
-    "parts": [
-      "live",
-      "",
-      "",
-      "",
-      "pulp",
-      ""
-    ],
-    "version": 0,
-    "group": "live",
-    "function": "",
-    "number": "",
-    "number_string": "",
-    "context": "",
-    "stage": "pulp",
-    "id": ""
-  },
-  "group": "live",
-  "puppet_inventory_metadata": {
-    "packages": {
-      "collection_enabled": false,
-      "last_collection_time": "0.0s"
-    }
-  },
-  "function_number": "",
-  "virt_libvirt": false,
-  "stage": "pulp",
-  "mysql_server_id": 23179131,
-  "selinux_python_command": "python",
-  "is_pe": false,
-  "pe_patch": {
-    "package_updates": [
-
-    ],
-    "package_update_count": 0,
-    "missing_update_kbs": [
-
-    ],
-    "security_package_updates": [
-
-    ],
-    "security_package_update_count": 0,
-    "blackouts": {
-    },
-    "pinned_packages": [
-
-    ],
-    "last_run": {
-    },
-    "patch_group": "",
-    "reboot_override": "default",
-    "reboots": {
-      "reboot_required": "unknown"
-    },
-    "block_patching_on_warnings": "false",
-    "warnings": {
-      "update_file": "Update file not found, update information invalid",
-      "security_update_file": "Security update file not found, update information invalid"
-    },
-    "blocked": false,
-    "blocked_reasons": [
-
-    ]
-  }
+  "lvm_pv_0": "/dev/sda2"
 }
diff --git a/facts/4.0/solaris-11-sun4v.facts b/facts/4.0/solaris-11-sun4v.facts
@@ -496,56 +496,24 @@
     }
   },
   "puppetversion": "7.5.0",
-  "mysql_server_id": 21745941,
-  "prometheus_alert_manager_running": false,
   "java_patch_level": "60",
-  "env_temp_variable": "/tmp",
   "mongodb_is_master": "not_installed",
-  "puppet_ssldir": "/etc/puppetlabs/puppet/ssl",
-  "puppet_digest_algorithm": "sha256",
-  "puppet_config": "/etc/puppetlabs/puppet/puppet.conf",
-  "puppet_stringify_facts": false,
   "mco_confdir": "/etc/mcollective/etc",
-  "stage": "1",
   "platform_symlink_writable": true,
-  "aio_agent_build": "7.4.1.59.g5d5199a8a",
   "platform_tag": "solaris-11-sparc",
   "java_version": "1.8.0_60",
   "staging_http_get": "curl",
   "current_environment": "production",
-  "classification": {
-    "hostname": "sol11-1",
-    "parts": [
-      "sol",
-      "",
-      "",
-      "",
-      "1",
-      ""
-    ],
-    "version": 0,
-    "group": "sol",
-    "function": "",
-    "number": "",
-    "number_string": "",
-    "context": "",
-    "stage": "1",
-    "id": ""
-  },
   "puppet_files_dir_present": false,
-  "function_number": "",
   "primary_iface": "eth0",
   "whereami": "opdx",
-  "virt_libvirt": false,
   "java_major_version": "8",
   "haszfs": true,
   "vcsrepo_svn_ver": "",
   "number_string": "",
   "function": "",
   "os_maj_version": "11",
   "group": "sol",
-  "python_version": "2.7.9",
-  "python2_version": "2.7.9",
   "windows_java_temp": "\\tmp",
   "puppet_cert_paths": {
     "confdir": "/etc/puppetlabs/puppet",
@@ -559,15 +527,7 @@
   "python_release": "2.7",
   "python2_release": "2.7",
   "primary_ip": "10.32.115.206",
-  "is_pe": false,
   "is_valid_hostname": false,
-  "puppet_inventory_metadata": {
-    "packages": {
-      "collection_enabled": false,
-      "last_collection_time": "0.0s"
-    }
-  },
-  "puppet_agent_pid": 2288,
   "puppetserver_installed": false,
   "context": "",
   "pip_version": "6.0.8",