Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup for rubocop #50

Merged
merged 2 commits into from
Jun 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,17 @@ env:
BUNDLE_WITHOUT: release

jobs:
# rubocop is currently not included in Gemfile
# rubocop:
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v4
# - name: Install Ruby 3.1
# uses: ruby/setup-ruby@v1
# with:
# ruby-version: "3.1"
# bundler-cache: true
# - name: Run rubocop
# run: bundle exec rake rubocop
rubocop:
silug marked this conversation as resolved.
Show resolved Hide resolved
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Install Ruby 3.3
uses: ruby/setup-ruby@v1
with:
ruby-version: "3.3"
bundler-cache: true
- name: Run rubocop
run: bundle exec rake rubocop
test:
runs-on: ubuntu-latest
strategy:
Expand All @@ -44,3 +43,12 @@ jobs:
# Currently no tests are defined in this gem
# - name: Run spec tests
# run: bundle exec rake

tests:
needs:
- rubocop
- test
runs-on: ubuntu-latest
name: Test suite
steps:
- run: echo Test suite completed
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ coverage
.bundle
.vendor
_vendor
/vendor/
tmp/
doc
# JetBrains IDEA
Expand Down
Loading