Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/pdaf #16

Merged
merged 31 commits into from
May 11, 2024
Merged

Feature/pdaf #16

merged 31 commits into from
May 11, 2024

Conversation

TristanWolfram
Copy link
Contributor

@TristanWolfram TristanWolfram commented Mar 18, 2024 •
edited
Loading

Target tracking feature

  • Implemented PDAF and IPDA with the use of vortex_filtering package (made by Eirik).
  • This will be used for target tracking tasks.

TristanWolfram and others added 23 commits March 18, 2024 13:04
@TristanWolfram @EirikKolas
Created new branch feature/pdaf
3d7b49f
@TristanWolfram @EirikKolas
Finalized PDAF class and added some tests
f92bc8c
@TristanWolfram @EirikKolas
Added axis tests for PDAF
9c37c74
@TristanWolfram @EirikKolas
finished basic testing!
09d6144
@TristanWolfram @EirikKolas
addded some more visualization
1644003
@TristanWolfram @EirikKolas
🐛 Refactor PDAF class to be without parameters
75be4f6
@TristanWolfram @EirikKolas
Add pragma once directive and update plot objects in pdaf_test.cpp
7bc7792
@iTroned @EirikKolas
ipda impl
d51fad9
@TristanWolfram @EirikKolas
⚡️ Refactor plotting code in pdaf_test.cpp
ba2d844
@TristanWolfram @EirikKolas
✅ added more tests
0e4d172
@EirikKolas
Committing clang-format changes
87ffbf7
@iTroned @EirikKolas
"da er ipda ferdig" -Eirik
f86ea0b
@TristanWolfram @EirikKolas
🚀 reformat code
1f56997
@TristanWolfram @EirikKolas
♻️ Refactor PDAF class and apply static methods
9ea647f
@TristanWolfram @EirikKolas
fixed gate bug
7d4f712
@etfroeland @EirikKolas
fixed ipda :)
9da7b3f
@TristanWolfram @EirikKolas
removed prints
a0571b0
@TristanWolfram @EirikKolas
Refactor IPDA class and add IPDA unit tests
5f240ea
@TristanWolfram @EirikKolas
removed fake pdaf in ipda
c09c6f0
@TristanWolfram @EirikKolas
Add IPDA test and update IPDA class***
4800f26
@TristanWolfram @EirikKolas
Refactor PDAF::predict_next_state to PDAF::step
d3dcbd1
@TristanWolfram @EirikKolas
💫 adden min and max distance threshold
aeeb0f4
@EirikKolas
refactored pdaf to work with new type system
68708dd
@TristanWolfram TristanWolfram linked an issue Mar 18, 2024 that may be closed by this pull request
[TASK] IPDA #4
Closed
3 tasks
EirikKolas
EirikKolas reviewed Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@EirikKolas EirikKolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also update the readme in the filters folter with an explanation of how the PDAF and IPDA works

vortex-filtering/include/vortex_filtering/filters/ipda.hpp Outdated Show resolved Hide resolved
vortex-filtering/include/vortex_filtering/filters/ipda.hpp Show resolved Hide resolved
vortex-filtering/include/vortex_filtering/filters/ipda.hpp Outdated Show resolved Hide resolved
vortex-filtering/include/vortex_filtering/filters/ipda.hpp Outdated Show resolved Hide resolved
vortex-filtering/include/vortex_filtering/filters/pdaf.hpp Outdated Show resolved Hide resolved
vortex-filtering/include/vortex_filtering/filters/pdaf.hpp Show resolved Hide resolved
vortex-filtering/include/vortex_filtering/filters/pdaf.hpp Outdated Show resolved Hide resolved
vortex-filtering/include/vortex_filtering/filters/pdaf.hpp Outdated Show resolved Hide resolved
vortex-filtering/test/ipda_test.cpp Outdated Show resolved Hide resolved
vortex-filtering/test/pdaf_test.cpp Outdated Show resolved Hide resolved
@EirikKolas EirikKolas linked an issue Mar 18, 2024 that may be closed by this pull request
[TASK] PDAF #2
Closed
7 tasks
@EirikKolas EirikKolas self-requested a review March 28, 2024 12:02
EirikKolas
EirikKolas reviewed Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@EirikKolas EirikKolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice readme. Please have a look through the rest of my comments from the previous review

vortex-filtering/include/vortex_filtering/filters/README.md Outdated Show resolved Hide resolved
vortex-filtering/include/vortex_filtering/filters/README.md Show resolved Hide resolved
vortex-filtering/include/vortex_filtering/filters/README.md Outdated Show resolved Hide resolved
vortex-filtering/include/vortex_filtering/filters/README.md Show resolved Hide resolved
vortex-filtering/include/vortex_filtering/filters/README.md Outdated Show resolved Hide resolved
vortex-filtering/include/vortex_filtering/filters/ipda.hpp Show resolved Hide resolved
vortex-filtering/include/vortex_filtering/filters/pdaf.hpp Show resolved Hide resolved
EirikKolas
EirikKolas approved these changes May 11, 2024
View reviewed changes
Copy link
Collaborator

@EirikKolas EirikKolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!!

@EirikKolas EirikKolas merged commit 3d371c9 into main May 11, 2024
6 checks passed
@EirikKolas EirikKolas deleted the feature/pdaf branch May 11, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EirikKolas EirikKolas EirikKolas approved these changes

@chrstrom chrstrom Awaiting requested review from chrstrom

Assignees

@TristanWolfram TristanWolfram

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK] IPDA [TASK] PDAF
4 participants
@TristanWolfram @EirikKolas @iTroned @etfroeland