Silence deprecation warning from the rename of Module#parent to Module#module_parent
#345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dule#module_parent` Rails 6 deprecated `Module#parent` and friends in rails/rails#34051, replacing them with a `module_*`-prefix naming scheme. This checks to see if `module_parent` is defined, using it if it's available.
agrobbin
changed the title
Module#parent to Module#module_parentModule#parent to Module#module_parent
|
I really hope the CI builds failing are resolved and that this gets merged and released. This will resolve #358 |
|
@agrobbin - I know it's been over a year, but is there any chance you would be able to see why the builds are failing and get them passing again? |
ghost
mentioned this pull request
Merged
|
FYI this PR can be closed in favor of: #365 |
Hossam-Hawary
added a commit
to Hossam-Hawary/activeadmin_addons
that referenced
this pull request
Jun 12, 2022
|
Thanks, @cooperka ..and sorry, folks, for the long period of silence here - I can only beg "pandemic" as an excuse. If this is still an issue, feel free to open against 1.7.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 6 deprecated
Module#parentand friends in rails/rails#34051, replacing them with amodule_*-prefix naming scheme. This checks to see ifmodule_parentis defined, using it if it's available.