Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized sidebar to make it responsive #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vaishnavi192
Copy link

@vaishnavi192 vaishnavi192 commented Feb 17, 2025

Solves #30
On large screens (>= 768px), the drawer starts open and permanent.
On small screens (< 768px), the drawer starts closed and temporary (slides in/out).
Manually clicking the menu button still works.

This will now fully adapt to different screen sizes and work perfectly on mobile devices too.

@volcano-sh-bot
Copy link
Contributor

Welcome @vaishnavi192!

It looks like this is your first PR to volcano-sh/dashboard.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: vaishnavi maheshwari <[email protected]>
@Monokaix
Copy link
Member

That's great! But actually the dashboard is rarely used in mobile : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants