-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Drawer Overlay Behavior to Prevent Content Shifting #22
base: main
Are you sure you want to change the base?
Conversation
/assign @kevin-wangzefeng |
Is this just a display optimization, or does this original layout may cause the page layout to be messed up when the window size changes? |
Thanks for your PR, is it possible for users to pin the drawer on the left? |
+1 |
no original layout will not cause the page layout to be messed up when the window size changes. |
should i pin it permanently??? |
@Monokaix @kevin-wangzefeng this button still follows the behaviour of drawer properties |
/lgtm |
Please squash to one commit: ) |
b8ca3d9
to
1d43db0
Compare
Signed-off-by: Shruti78 <[email protected]> fixed logo fix issue Signed-off-by: Shruti78 <[email protected]> Save changes to Queues.jsx
1d43db0
to
780acca
Compare
@Monokaix done But I want to ask you is this behaviour ok with the drawer?? |
It's ok |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
thanks
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kevin-wangzefeng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #21
Description:
This pull request addresses the issue where opening the drawer causes the main content to shift rightward. Instead, the drawer will now overlay the content, maintaining a stable layout and improving the user experience.
Changes Made:
Before:
After:
Impact:
This update improves UI stability and enhances the user experience across all screen sizes