Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Drawer Overlay Behavior to Prevent Content Shifting #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Shrutim1505
Copy link
Contributor

Fixes #21
Description:
This pull request addresses the issue where opening the drawer causes the main content to shift rightward. Instead, the drawer will now overlay the content, maintaining a stable layout and improving the user experience.

Changes Made:

  • Added a Backdrop component to improve visibility when the drawer is open.
  • Enabled clicking outside the drawer to close it automatically.

Before:

Screenshot from 2025-02-10 20-06-00

After:

image

Impact:
This update improves UI stability and enhances the user experience across all screen sizes

@Shrutim1505
Copy link
Contributor Author

/assign @kevin-wangzefeng

@JesseStutler
Copy link
Member

JesseStutler commented Feb 11, 2025

Is this just a display optimization, or does this original layout may cause the page layout to be messed up when the window size changes?

@kevin-wangzefeng
Copy link
Member

Thanks for your PR, is it possible for users to pin the drawer on the left?
Someone may prefer always show drawer on the left.

@Monokaix
Copy link
Member

Thanks for your PR, is it possible for users to pin the drawer on the left? Someone may prefer always show drawer on the left.

+1

@Shrutim1505
Copy link
Contributor Author

Is this just a display optimization, or does this original layout may cause the page layout to be messed up when the window size changes?

no original layout will not cause the page layout to be messed up when the window size changes.

@Shrutim1505
Copy link
Contributor Author

Shrutim1505 commented Feb 11, 2025

Thanks for your PR, is it possible for users to pin the drawer on the left? Someone may prefer always show drawer on the left.

should i pin it permanently???
changed from original look???

@Monokaix
Copy link
Member

Thanks for your PR, is it possible for users to pin the drawer on the left? Someone may prefer always show drawer on the left.

should i pin it permanently??? changed from original look???

I think users can pin or

Thanks for your PR, is it possible for users to pin the drawer on the left? Someone may prefer always show drawer on the left.

should i pin it permanently??? changed from original look???

Does this button still take effect? We can fold or unfold it.
1

@Shrutim1505
Copy link
Contributor Author

Thanks for your PR, is it possible for users to pin the drawer on the left? Someone may prefer always show drawer on the left.

should i pin it permanently??? changed from original look???

I think users can pin or

Thanks for your PR, is it possible for users to pin the drawer on the left? Someone may prefer always show drawer on the left.

should i pin it permanently??? changed from original look???

Does this button still take effect? We can fold or unfold it. 1

yes

@Shrutim1505
Copy link
Contributor Author

@Monokaix @kevin-wangzefeng this button still follows the behaviour of drawer properties

@Monokaix
Copy link
Member

/lgtm

@Monokaix
Copy link
Member

Please squash to one commit: )

Signed-off-by: Shruti78 <[email protected]>

fixed logo fix  issue

Signed-off-by: Shruti78 <[email protected]>

Save changes to Queues.jsx
@Shrutim1505
Copy link
Contributor Author

@Monokaix done

But I want to ask you is this behaviour ok with the drawer??
It will open on clicking the button there

image

@Monokaix
Copy link
Member

But I want to ask you is this behaviour ok with the drawer??
It will open on clicking the button there

It's ok

@Monokaix
Copy link
Member

/lgtm

Copy link
Member

@kevin-wangzefeng kevin-wangzefeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
thanks

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevin-wangzefeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Drawer Behavior: Prevent Content from Shifting on Open
5 participants