Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/ui] : ReVamping the Volcano Dashboard , UI #17

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

de6p
Copy link

@de6p de6p commented Feb 8, 2025

PR Description:
We are revamping the Volcano dashboard UI by migrating to a newer framework with more maintainable code. We have decided to use Next.js as the framework and Tailwind CSS for styling, making it easier for contributors to contribute while also reducing the package size, which improves the app's performance.

Additionally, there are several backend optimizations that can be made. I can draft a proposal outlining those improvements as well.

Looking forward to hearing back from the maintainers.

Also added support for Typescript .

here is look ->
@Monokaix

image

@de6p
Copy link
Author

de6p commented Feb 11, 2025

/assign @Monokaix

@Monokaix
Copy link
Member

This seems a huge change, can you split into somes small pr like style/frontend/backend, etc. changes?

@JesseStutler
Copy link
Member

It's a huge change, I would like to ask that does Next.js and Tailwind CSS are leading technologies in the industry? I'm not familiar with frontend technologies. Besides, dashboard is going to have a LFX project right now, it will influence the mentee to contribute.

@de6p
Copy link
Author

de6p commented Feb 12, 2025

It's a huge change, I would like to ask that does Next.js and Tailwind CSS are leading technologies in the industry? I'm not familiar with frontend technologies. Besides, dashboard is going to have a LFX project right now, it will influence the mentee to contribute.

This PR focuses on the frontend/style changes. I'll address the backend updates after this PR is merged

@de6p
Copy link
Author

de6p commented Feb 12, 2025

It's a huge change, I would like to ask that does Next.js and Tailwind CSS are leading technologies in the industry? I'm not familiar with frontend technologies. Besides, dashboard is going to have a LFX project right now, it will influence the mentee to contribute.

Next.js and Tailwind CSS are widely used for their scalability and ease of use. Next.js supports SSR, SSG, and API routes, while Tailwind’s utility-first approach makes styling efficient. Since this is an LFX project, these technologies help mentees contribute easily. This PR showcases my ability to enhance the volcano dashboard, and I’m interested in joining Term 1 under the LFX mentorship.

@de6p
Copy link
Author

de6p commented Feb 12, 2025

I know these changes are quite large, but I'm going all-in on the frontend updates in this one PR to ensure that all the features of the Volcano dashboard are included and fully functional. It may seem like a lot, but once it's ready, I’m confident you’ll love the new UI!

@de6p
Copy link
Author

de6p commented Feb 12, 2025

We could have a brief meeting where I can walk you through the changes. I’d love the opportunity to discuss everything in more detail.

@Monokaix @JesseStutler

@JesseStutler
Copy link
Member

We're not familiar with frontend technologies, so if you want to make the dashboard more beautiful, we're willing to see that. There are other people would like to use some CSS/js framework to enhance visualization, I don't know whether your guys will conflict with each other. I think the style can be made more beautiful, but if the way of codes to connect to kubernetes will change, I don't want to see this.

@de6p
Copy link
Author

de6p commented Feb 12, 2025

Since Next.js is fully compatible with React, and Tailwind is just a styling improvement, there’s no conflict with any CSS/JS framework others may want to use. They can still add their enhancements on top of this setup.

@de6p
Copy link
Author

de6p commented Feb 12, 2025

Next.js builds on React.js, meaning all React components still work the same way. The only difference is that we now have better performance optimizations, faster page loads and many much.

@de6p
Copy link
Author

de6p commented Feb 12, 2025

The way the dashboard connects to Kubernetes remains exactly the same. The backend logic, API calls, and data handling have not been altered.

@de6p
Copy link
Author

de6p commented Feb 13, 2025

I've just updated the jobs page. Currently, it contains sample data, but we will update it once everything is finalized.

image

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign monokaix
You can assign the PR to them by writing /assign @monokaix in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants