Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-server, vscode): Properly handle FS requests on browser #73

Merged
merged 12 commits into from
Nov 3, 2023

Conversation

johnsoncodehk
Copy link
Member

@johnsoncodehk johnsoncodehk commented Nov 2, 2023

This PR only affects the browser language server.

  • Determine whether to send fs.readDirectory, fs.readFile requests based on mtime response by fs.stat, otherwise use the workspaceState cache This reduces performance in real-world situations
  • Loading files should show a progress bar
  • language server no longer caches readDirectory

@johnsoncodehk johnsoncodehk changed the title perf(language-server, vscode): Properly cache FS requests perf(language-server, vscode): Properly cache FS requests on browser Nov 2, 2023
@johnsoncodehk johnsoncodehk changed the title perf(language-server, vscode): Properly cache FS requests on browser fix(language-server, vscode): Properly handle FS requests on browser Nov 3, 2023
@johnsoncodehk johnsoncodehk merged commit 28a8b9f into master Nov 3, 2023
6 checks passed
@johnsoncodehk johnsoncodehk deleted the web-fs branch November 3, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant