kodi-addon-inputstream-adaptive: update to 21.4.4. #54016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| checksum=353207f5f98bf81ce8d79cec903c28da8c0227d7c7a632692c910d81e59c2dbe | ||
| # Bento4 version defined in https://github.com/xbmc/inputstream.adaptive/blob/Piers/depends/common/bento4/bento4.txt | ||
| _bento4_version=1.6.0-641-Omega | ||
| _bento4_tarball=${_bento4_version}.tar.gz |
There was a problem hiding this comment.
this is only referenced in a couple places, can those places just use ${_bento4_version}.tar.gz directly?
There was a problem hiding this comment.
Any objection if I just remove the _bento4_version variable instead? I've realised I no longer reference that anywhere else
There was a problem hiding this comment.
no that's still useful. we usually put those variables up near the primary version (so after the _kodi_release line)
There was a problem hiding this comment.
Thanks for the explanation, done.
|
|
||
| # Inputstream Adaptive needs the unextracted tarball | ||
| skip_extraction="${_bento4_tarball}" | ||
| configure_args=" -DENABLE_INTERNAL_BENTO4=1 -DBENTO4_URL=${XBPS_SRCDISTDIR}/${pkgname}-${version}/${_bento4_tarball} -DVERBOSE=1" |
There was a problem hiding this comment.
this should go up in the first block, after build_style
thespookman
force-pushed
the
update-kodi-addon-inputstream-adaptive
branch
from
01763e5 to
7b40831
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing
Closes #53872