Cancel any previous fetchAccount calls via axios #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a trick in order to avoid a race condition that happened sometimes (< 3% of the times) for people having a metamask wallet connected to the application. Wallets load the first thing when you refresh a page, because they're browser extensions. Sometimes though, the wallet may load a bit later, causing its `fetchAccount` call to be computed after the same call done by the remote signer. This caused the remote signer to be set with the wrong address only in part of the state, causing the app to crash in some points with an "Unknown account" error.
gerouvi
pushed a commit
that referenced
this pull request
Jan 26, 2025
This is a trick in order to avoid a race condition that happened sometimes (< 3% of the times) for people having a metamask wallet connected to the application. Wallets load the first thing when you refresh a page, because they're browser extensions. Sometimes though, the wallet may load a bit later, causing its `fetchAccount` call to be computed after the same call done by the remote signer. This caused the remote signer to be set with the wrong address only in part of the state, causing the app to crash in some points with an "Unknown account" error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a trick in order to avoid a race condition that happened sometimes (< 3% of the times) for people having a wallet connected to the application. Wallets are the first thing to load when you refresh a page, because they're browser extensions. Sometimes though, the wallet may load a bit later, causing its
fetchAccountcall to be computed after the same call done by the remote signer. This caused the remote signer to be set with the wrong address only in part of the state, causing the app to crash in some points with an "Unknown account" error.