Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new stats/home page #82

Merged
merged 43 commits into from
Aug 20, 2024
Merged

Implement new stats/home page #82

merged 43 commits into from
Aug 20, 2024

Conversation

selankon
Copy link
Collaborator

@selankon selankon commented Jul 31, 2024

Fixes #77

Needs sdk: vocdoni/vocdoni-sdk#406
Extended sdk: vocdoni/ui-components#195

Copy link

github-actions bot commented Jul 31, 2024

@github-actions github-actions bot temporarily deployed to pull request July 31, 2024 09:52 Inactive
Copy link

github-actions bot commented Jul 31, 2024

@github-actions github-actions bot temporarily deployed to pull request July 31, 2024 09:52 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 31, 2024 10:07 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 31, 2024 10:07 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 08:22 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 08:22 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 08:48 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 08:48 Inactive
@selankon selankon force-pushed the f/implement-new-landing branch from 8d19c92 to 2d76158 Compare August 1, 2024 08:57
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 08:58 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 08:58 Inactive
@selankon selankon force-pushed the f/implement-new-landing branch from 2d76158 to 435f8ee Compare August 1, 2024 09:23
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 09:24 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 09:24 Inactive
@selankon selankon force-pushed the f/implement-new-landing branch from 435f8ee to 28fddc8 Compare August 1, 2024 10:02
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 10:03 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 10:03 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 10:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 10:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 10:34 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 10:34 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 10:44 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 10:44 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 2, 2024 08:12 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 2, 2024 08:13 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 2, 2024 08:22 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 2, 2024 08:22 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 19, 2024 09:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 19, 2024 09:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 19, 2024 09:26 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 19, 2024 09:26 Inactive
@selankon selankon marked this pull request as ready for review August 19, 2024 09:44
@github-actions github-actions bot temporarily deployed to pull request August 19, 2024 10:06 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 19, 2024 10:06 Inactive
This way the price factors and VOC tokens price are shown inside two separated modals that can be opened from the Blockhain info card
@github-actions github-actions bot temporarily deployed to pull request August 19, 2024 11:01 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 19, 2024 11:01 Inactive
Copy link
Member

@elboletaire elboletaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor issues, other than that LGTM

src/components/Stats/ChainDetails/TxCosts.tsx Outdated Show resolved Hide resolved
- Delete commented
- Comment useEffect
@selankon selankon requested a review from elboletaire August 20, 2024 07:49
@github-actions github-actions bot temporarily deployed to pull request August 20, 2024 07:49 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 20, 2024 07:49 Inactive
@elboletaire elboletaire merged commit eeb658c into main Aug 20, 2024
3 checks passed
@elboletaire elboletaire deleted the f/implement-new-landing branch August 20, 2024 08:34
@elboletaire elboletaire mentioned this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Main page improvements
2 participants