Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix race condition on channel #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Fix race condition on channel #28

wants to merge 1 commit into from

Conversation

hermanschaaf
Copy link

This should fix two issues:

panic: close of closed channel

goroutine 1337 [running]:
github.com/vnteamopen/godebouncer.(*Debouncer).invokeTriggeredFunc.func1()
	/home/runner/go/pkg/mod/github.com/vnteamopen/[email protected]/debouncer.go:124 +0x85
created by time.goFunc
	/opt/hostedtoolcache/go/1.21.5/x64/src/time/sleep.go:176 +0x45

and a data race, as can be seen in the CI build here.

@hermanschaaf hermanschaaf mentioned this pull request Feb 20, 2024
Merged
@erezrokah erezrokah mentioned this pull request Aug 9, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disq disq disq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hermanschaaf @disq