🌱 Do not requeue VMIC for empty Spec fields #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If these empty Spec fields are updated, the Watch() will cause the controller to reconcile the object. Add NoRequeueError that returns the controller-runtime TerminalError that does not do a requeue but is logged and counted as an error. While here, update the VMIC ReconcileNormal() to use the logger from the context instead of parent reconciler so the object name is still there.
bryanv
force-pushed
the
bryanv/dont-requeue-for-vmic-empty-errors
branch
from
98f06cf to
6ff12ad
Compare
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
If these empty Spec fields are updated, the Watch() will cause the controller to reconcile the object so we don't need to do a requeue.
Add NoRequeueError that returns the controller-runtime TerminalError that does not do a requeue but is logged and counted as an error.
While here, update the VMIC ReconcileNormal() to use the logger from the context instead of parent reconciler so the object name is still there.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
There are a few other ways to do this:
Also TerminalError has a confusing name: it just causes the object to not be requeued, but can be later queue due to an event from like a watch.
Please add a release note if necessary: