🌱 Include UUID of disk backing in disk backup #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreyasn
approved these changes
Jan 23, 2025
aruneshpa
force-pushed
the
feature/use-disk-uuid-for-srm
branch
3 times, most recently
from
a3b0983 to
4c5c4f7
Compare
github-actions
bot
added
size/S
aruneshpa
force-pushed
the
feature/use-disk-uuid-for-srm
branch
2 times, most recently
from
1172c12 to
ef81425
Compare
Minimum allowed line rate is |
akutz
reviewed
Jan 24, 2025
aruneshpa
changed the title
This change modifies the disk backups to also include disk backing UUIDs. This allows us to look up and identify disks using UUIDs to differentiate classic disks from disks that should be FCDs. For now, the disk UUIDs are only used in failover workflows since vSphere Replication guarantees that the disks will be restored with the same UUID as the primary/source.
aruneshpa
force-pushed
the
feature/use-disk-uuid-for-srm
branch
from
ef81425 to
3f27959
Compare
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This change modifies the disk backup to also include disk UUIDs. This allows us to look up and identify disks using UUIDs to differentiate classic disks from disks that should be FCDs.
For now, the disk UUIDs are only used in failover workflows since vSphere Replication guarantees that the disks will be restored with the same UUID as the primary/source.
Are there any special notes for your reviewer:
This change is specific for failover of VMs.
Please add a release note if necessary: