✨ Support v1a2 VirtualMachine full version conversion #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing-needed-e2e-fast
size/L
The difference between v1a1 and v1a2 VMs is pretty large, and a lot of v1a2 fields are new so there is nothing corresponding in v1a1 to be able to down convert to v1a1, and then back to v1a2. This means that, if set, the new v1a2 fields would be lost on a version conversion round trip. Use the CAPI trick to store the serialized object in the annotations, and then deser it restore the v1a2 fields. This does get a little messy when we have to try to potentially merge updates down in v1a1 with the restored v1a2 fields.
bryanv
force-pushed
the
bryanv/virtual-machine-full-version-conversion
branch
from
874a140 to
60973fc
Compare
Minimum allowed line rate is |
bryanv
added
the
testing-done-e2e-fast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The difference between v1a1 and v1a2 VMs is pretty large, and a lot of v1a2 fields are new so there is nothing corresponding in v1a1 to be able to down convert to v1a1, and then back to v1a2. This means that, if set, the new v1a2 fields would be lost on a version conversion round trip.
Use the CAPI trick to store the serialized object in the annotations, and then deser it restore the v1a2 fields. This does get a little messy when we have to try to potentially merge updates down in v1a1 with the restored v1a2 fields.