🌱 Update deprecated pr labeler version #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump the version of the PR Labeler action, updating to the newer configuration schema. The size configuration was changed a few versions ago. I'm looking to remove support so I'm sending some PRs to the very few repos that still rely on it. I updated the reference to the action to master. This actually uses the latest stable version so it should avoid any unintended breakage. Thanks for using the action! Signed-off-by: Galo Navarro <[email protected]>
|
@srvaroa, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
|
@srvaroa, VMware has approved your signed contributor license agreement. |
akutz
reviewed
Dec 26, 2023
.github/workflows/pr-labeler.yml
Outdated
| @@ -31,7 +31,7 @@ jobs: | |||
| # - "config/crd/bases/.*" # generated CRDs | |||
| # - "docs/apis/v*.md" # generated API documentation, | |||
| # # ex. docs/apis/v1alpha1.md | |||
| - uses: srvaroa/labeler@v0.9 | |||
| - uses: srvaroa/labeler@master | |||
There was a problem hiding this comment.
We want to avoid sliding version targets. Please point to a specific version instead.
There was a problem hiding this comment.
Thanks for the review, fixed!
|
@srvaroa By the way, thank you very much for such a fantastic GitHub action! |
Pin to v1.9.0
|
Thanks @akutz ! I have pinned the version to the latest available. |
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
Bump the version of the PR Labeler action, updating to the newer configuration schema. The size configuration was changed a few versions ago. I'm looking to remove support so I'm sending some PRs to the very few repos that still rely on it.
I updated the reference to the action to master. This actually uses the latest stable version so it should avoid any unintended breakage.
Thanks for using the action!